Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2615633010: kiosk: Add kiosk.always_update manifest key (Closed)

Created:
3 years, 11 months ago by xiyuan
Modified:
3 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Add kiosk.always_update manifest key If the key is specified and its value is true, it allows the app to be always updated regardless of whether the underlying platform is compliant or not. If the value is false or the key is not specified, the required platform version is respected and the app update is deferred until the underlying platform becomes compliant. BUG=673527 Review-Url: https://codereview.chromium.org/2615633010 Cr-Commit-Position: refs/heads/master@{#444163} Committed: https://chromium.googlesource.com/chromium/src/+/5000d8c6bb918bf57ea1693aca99524074b78f2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -6 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/manifest_constants.h View 3 chunks +2 lines, -1 line 0 comments Download
M extensions/common/manifest_constants.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/common/manifest_handlers/kiosk_mode_info.h View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/common/manifest_handlers/kiosk_mode_info.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M extensions/common/manifest_handlers/kiosk_mode_info_unittest.cc View 2 chunks +22 lines, -1 line 0 comments Download
A extensions/test/data/manifest_tests/kiosk_always_update.json View 1 chunk +15 lines, -0 lines 0 comments Download
A extensions/test/data/manifest_tests/kiosk_always_update_false.json View 1 chunk +15 lines, -0 lines 0 comments Download
A extensions/test/data/manifest_tests/kiosk_always_update_invalid.json View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
xiyuan
3 years, 11 months ago (2017-01-05 20:23:22 UTC) #4
Rahul Chaturvedi
lgtm
3 years, 11 months ago (2017-01-06 20:12:09 UTC) #7
xiyuan
rdevlin.cronin@, could you help to review this as well? Thanks.
3 years, 11 months ago (2017-01-06 20:36:29 UTC) #9
Devlin
On 2017/01/06 20:36:29, xiyuan wrote: > rdevlin.cronin@, could you help to review this as well? ...
3 years, 11 months ago (2017-01-09 23:51:16 UTC) #10
Devlin
extensions lgtm
3 years, 11 months ago (2017-01-17 21:16:14 UTC) #11
xiyuan
Thank you for the review.
3 years, 11 months ago (2017-01-17 21:17:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615633010/1
3 years, 11 months ago (2017-01-17 21:18:28 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 22:24:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5000d8c6bb918bf57ea1693aca99...

Powered by Google App Engine
This is Rietveld 408576698