Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2615633007:
Change net/base/escape.h to use StringPiece. (Closed)
|
Created:
3 years, 11 months ago by Sam McNally Modified:
3 years, 11 months ago Reviewers:
mmenke CC:
chromium-reviews, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange net/base/escape.h to use StringPiece.
BUG=678837
Review-Url: https://codereview.chromium.org/2615633007
Cr-Commit-Position: refs/heads/master@{#441791}
Committed: https://chromium.googlesource.com/chromium/src/+/27b95a92306e43c448f2f863c0bf10eae60fd625
Patch Set 1 : #
Total comments: 4
Patch Set 2 : #
Messages
Total messages: 26 (19 generated)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
sammc@chromium.org changed reviewers: + mmenke@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Just some nits. Could you add a bug for this? If it's part of some larger optimization project, some more general meta-bug is fine. If not, just file a new one. https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc File net/base/escape.cc (left): https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc#oldc... net/base/escape.cc:13: #include "base/strings/utf_offset_string_conversions.h" This is needed for UTF8ToUTF16WithAdjustments, no? https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc File net/base/escape.cc (right): https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc#newc... net/base/escape.cc:18: using StringTypeForStringPiece = decltype(std::declval<STR>().as_string()); I think this is sufficiently obscure that it needs a comment. (It's C++0x11 that is unlikely to ever see common enough use for people to intuitively know what it actually does, and it's rather verbose as well)
https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc File net/base/escape.cc (left): https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc#oldc... net/base/escape.cc:13: #include "base/strings/utf_offset_string_conversions.h" On 2017/01/05 16:19:54, mmenke wrote: > This is needed for UTF8ToUTF16WithAdjustments, no? Oops, ignore this. I just assumed this was a method-only file, so naturally wouldn't be included in the header file (And I was wrong).
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Patchset #2 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Change net/base/escape.h to use StringPiece. ========== to ========== Change net/base/escape.h to use StringPiece. BUG=678837 ==========
On 2017/01/05 16:19:54, mmenke wrote: > Just some nits. Could you add a bug for this? If it's part of some larger > optimization project, some more general meta-bug is fine. If not, just file a > new one. > Done. https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc File net/base/escape.cc (right): https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc#newc... net/base/escape.cc:18: using StringTypeForStringPiece = decltype(std::declval<STR>().as_string()); On 2017/01/05 16:19:54, mmenke wrote: > I think this is sufficiently obscure that it needs a comment. (It's C++0x11 > that is unlikely to ever see common enough use for people to intuitively know > what it actually does, and it's rather verbose as well) I found an alternative that avoids this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/01/06 00:20:51, Sam McNally wrote: > On 2017/01/05 16:19:54, mmenke wrote: > > Just some nits. Could you add a bug for this? If it's part of some larger > > optimization project, some more general meta-bug is fine. If not, just file a > > new one. > > > Done. > > https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc > File net/base/escape.cc (right): > > https://codereview.chromium.org/2615633007/diff/20001/net/base/escape.cc#newc... > net/base/escape.cc:18: using StringTypeForStringPiece = > decltype(std::declval<STR>().as_string()); > On 2017/01/05 16:19:54, mmenke wrote: > > I think this is sufficiently obscure that it needs a comment. (It's C++0x11 > > that is unlikely to ever see common enough use for people to intuitively know > > what it actually does, and it's rather verbose as well) > > I found an alternative that avoids this. Great! LGTM, thanks for doing this!
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483665646896840,
"parent_rev": "2f1d5f56541d4200134418bff40902734d4fe7ce", "commit_rev":
"27b95a92306e43c448f2f863c0bf10eae60fd625"}
Message was sent while issue was closed.
Description was changed from ========== Change net/base/escape.h to use StringPiece. BUG=678837 ========== to ========== Change net/base/escape.h to use StringPiece. BUG=678837 Review-Url: https://codereview.chromium.org/2615633007 Cr-Commit-Position: refs/heads/master@{#441791} Committed: https://chromium.googlesource.com/chromium/src/+/27b95a92306e43c448f2f863c0bf... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/27b95a92306e43c448f2f863c0bf... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
