Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2615623003: [tools] Include full benchmark measurement name in error reporting (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Include full benchmark measurement name in error reporting For benchmarks with multiple measurements (e.g. runtime, compile time, generated code size), in case of error, we'd get only the last portion of the name ("Compile"), which is ambiguous and makes debugging dificult. This change includes the full name, e.g. "Unity/Physics/Compile". BUG= Review-Url: https://codereview.chromium.org/2615623003 Cr-Commit-Position: refs/heads/master@{#42078} Committed: https://chromium.googlesource.com/v8/v8/+/9e5a064197ca3db0ff39bcc04767494ead4aa929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/run_perf.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
3 years, 11 months ago (2017-01-04 17:34:13 UTC) #3
bradnelson
lgtm
3 years, 11 months ago (2017-01-04 23:15:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615623003/1
3 years, 11 months ago (2017-01-04 23:15:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/9e5a064197ca3db0ff39bcc04767494ead4aa929
3 years, 11 months ago (2017-01-04 23:36:11 UTC) #9
Michael Achenbach
3 years, 11 months ago (2017-01-05 15:01:59 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698