Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2615613009: Put Scene class into scene namespace. (Closed)

Created:
3 years, 11 months ago by cjgrant
Modified:
3 years, 11 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put Scene class into scene namespace. - Fix some confusing naming to be 10% less confusing. - Incorporate dbeam@'s object initialization advice. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2615613009 Cr-Commit-Position: refs/heads/master@{#442905} Committed: https://chromium.googlesource.com/chromium/src/+/1b58a6580431b43b893e2235bbbba2f527c4a0c0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 1 15 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui_api.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui_scene.js View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
cjgrant
3 years, 11 months ago (2017-01-06 20:37:23 UTC) #3
mthiesse
lgtm % nit https://codereview.chromium.org/2615613009/diff/1/chrome/browser/resources/vr_shell/vr_shell_ui_api.js File chrome/browser/resources/vr_shell/vr_shell_ui_api.js (right): https://codereview.chromium.org/2615613009/diff/1/chrome/browser/resources/vr_shell/vr_shell_ui_api.js#newcode5 chrome/browser/resources/vr_shell/vr_shell_ui_api.js:5: var api = {} nit: semicolon
3 years, 11 months ago (2017-01-09 15:17:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615613009/20001
3 years, 11 months ago (2017-01-11 01:46:33 UTC) #7
cjgrant
https://codereview.chromium.org/2615613009/diff/1/chrome/browser/resources/vr_shell/vr_shell_ui_api.js File chrome/browser/resources/vr_shell/vr_shell_ui_api.js (right): https://codereview.chromium.org/2615613009/diff/1/chrome/browser/resources/vr_shell/vr_shell_ui_api.js#newcode5 chrome/browser/resources/vr_shell/vr_shell_ui_api.js:5: var api = {} On 2017/01/09 15:17:09, mthiesse wrote: ...
3 years, 11 months ago (2017-01-11 01:49:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97658)
3 years, 11 months ago (2017-01-11 03:37:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615613009/20001
3 years, 11 months ago (2017-01-11 14:34:40 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 15:13:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b58a6580431b43b893e2235bbbb...

Powered by Google App Engine
This is Rietveld 408576698