Adding ChromeOS firmware version to feedback reports

Adding ChromeOS firmware version to feedback reports

Adding it such that it shows up in the product-specific data.

BUG=676017
TEST=Start the feedback app, open the system information link, an entry named
CHROMEOS_FIRMWARE_VERSION should be present with a valid value matching that in
/var/log/bios_info.txt.

Review-Url: https://codereview.chromium.org/2615603003
Cr-Commit-Position: refs/heads/master@{#441718}
Committed: https://chromium.googlesource.com/chromium/src/+/d671a25e63f03dd6389fae56d8e575820bda47b6

[afakhry, 2017-01-05 00:27:03]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 00:27:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-01-05 00:29:34]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2017-01-05 00:29:35]

Xiyuan, can you please review this simple CL? Thanks!

[afakhry, 2017-01-05 00:43:40]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 00:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 02:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 02:32:48]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-01-05 17:46:17]

lgtm

https://codereview.chromium.org/2615603003/diff/20001/chrome/browser/feedback...
File
chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
(right):

https://codereview.chromium.org/2615603003/diff/20001/chrome/browser/feedback...
chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc:72:
void GetBackgroundEntries(SystemLogsResponse* response) {
nit: If "background" here does not have special meanings other than running the
job on a background thread, suggest to 

  GetBackgroundEntries -> GetEntriesOnBlockingPool

to follow existing name convention and easier to read.

[afakhry, 2017-01-05 17:57:15]

https://codereview.chromium.org/2615603003/diff/20001/chrome/browser/feedback...
File
chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
(right):

https://codereview.chromium.org/2615603003/diff/20001/chrome/browser/feedback...
chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc:72:
void GetBackgroundEntries(SystemLogsResponse* response) {
On 2017/01/05 17:46:17, xiyuan wrote:
> nit: If "background" here does not have special meanings other than running
the
> job on a background thread, suggest to 
> 
>   GetBackgroundEntries -> GetEntriesOnBlockingPool
> 
> to follow existing name convention and easier to read.

Good suggestion. Thanks! Done.

[afakhry, 2017-01-05 17:57:31]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-01-05 17:57:31]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2615603003/#ps40001
(title: "Nit")

[commit-bot: I haz the power, 2017-01-05 17:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:54:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483639051490490,
"parent_rev": "91dde39f62bcd1c4e9803255d37c725c33557660", "commit_rev":
"d671a25e63f03dd6389fae56d8e575820bda47b6"}

[commit-bot: I haz the power, 2017-01-05 18:54:53]

Description was changed from

==========
Adding ChromeOS firmware version to feedback reports

Adding it such that it shows up in the product-specific data.

BUG=676017
TEST=Start the feedback app, open the system information link, an entry named
CHROMEOS_FIRMWARE_VERSION should be present with a valid value matching that in
/var/log/bios_info.txt.
==========

to

==========
Adding ChromeOS firmware version to feedback reports

Adding it such that it shows up in the product-specific data.

BUG=676017
TEST=Start the feedback app, open the system information link, an entry named
CHROMEOS_FIRMWARE_VERSION should be present with a valid value matching that in
/var/log/bios_info.txt.

Review-Url: https://codereview.chromium.org/2615603003
Cr-Commit-Position: refs/heads/master@{#441718}
Committed:
https://chromium.googlesource.com/chromium/src/+/d671a25e63f03dd6389fae56d8e5...
==========

[commit-bot: I haz the power, 2017-01-05 18:54:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d671a25e63f03dd6389fae56d8e5...