Add disable_program_caching_for_transform_feedback workaround.

Add disable_program_caching_for_transform_feedback workaround.

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7db45ad0084e0622951df2e14c4c411349ef7338
Cr-Commit-Position: refs/heads/master@{#441433}

[Ken Russell (switch to Gerrit), 2017-01-04 07:23:06]

Description was changed from

==========
Add disable_program_caching_for_transform_feedback workaround.

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
==========

to

==========
Add disable_program_caching_for_transform_feedback workaround.

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-01-04 07:24:42]

kbr@chromium.org changed reviewers:
+ vmiura@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2017-01-04 07:24:42]

Mo or Victor: could you please review?

In addition to the new unit test, tested locally and verified that the
webgl2-particles-2 demo works properly after being reloaded.

Kai, Yuly: FYI. This workaround will eventually need to be ported into ANGLE, I
think.

[Ken Russell (switch to Gerrit), 2017-01-04 07:24:51]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 07:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 09:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 09:03:35]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2017-01-04 18:25:22]

On 2017/01/04 07:24:42, Ken Russell wrote:
> Mo or Victor: could you please review?
> 
> In addition to the new unit test, tested locally and verified that the
> webgl2-particles-2 demo works properly after being reloaded.
> 
> Kai, Yuly: FYI. This workaround will eventually need to be ported into ANGLE,
I
> think.

lgtm

[Kai Ninomiya, 2017-01-04 18:32:34]

kainino@chromium.org changed reviewers:
+ kainino@chromium.org

[Kai Ninomiya, 2017-01-04 18:32:34]

lgtm

[Ken Russell (switch to Gerrit), 2017-01-04 19:19:28]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-01-04 19:19:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 19:26:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483557568514070, "parent_rev":
"b26ed2c3f7133b7eb6bc33a8b319ebd7ccf5c611", "commit_rev":
"8b68d4d53122692c6a2565b9e95eea6b327405fc"}

[commit-bot: I haz the power, 2017-01-04 19:27:04]

Description was changed from

==========
Add disable_program_caching_for_transform_feedback workaround.

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add disable_program_caching_for_transform_feedback workaround.

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2615573002
==========

[commit-bot: I haz the power, 2017-01-04 19:27:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 19:30:48]

Description was changed from

==========
Add disable_program_caching_for_transform_feedback workaround.

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2615573002
==========

to

==========
Add disable_program_caching_for_transform_feedback workaround.

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7db45ad0084e0622951df2e14c4c411349ef7338
Cr-Commit-Position: refs/heads/master@{#441433}
==========

[commit-bot: I haz the power, 2017-01-04 19:30:49]

Patchset 1 (id:??) landed as
https://crrev.com/7db45ad0084e0622951df2e14c4c411349ef7338
Cr-Commit-Position: refs/heads/master@{#441433}