Remove duplicate domHighResTimestamp conversion in NavigationTiming

Remove duplicate domHighResTimestamp conversion in NavigationTiming and ResourceTiming

BUG=676180
Review-Url: https://codereview.chromium.org/2615533002
Cr-Commit-Position: refs/heads/master@{#442474}
Committed: https://chromium.googlesource.com/chromium/src/+/f4fb16ccc801791db8d03b8f4cc8393fa36000fb

[sunjian, 2017-01-03 23:13:31]

sunjian@chromium.org changed reviewers:
+ panicker@chromium.org

[panicker, 2017-01-04 20:54:30]

https://codereview.chromium.org/2615533002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
(left):

https://codereview.chromium.org/2615533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp:12: //
TODO(sunjian): Move this logic into PerformanceBase
Let's remove the redundant one in ResourceTiming as well while we are at it:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/timing/Pe...

[sunjian, 2017-01-05 00:34:33]

Patchset #2 (id:20001) has been deleted

[sunjian, 2017-01-05 00:52:13]

https://codereview.chromium.org/2615533002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp
(left):

https://codereview.chromium.org/2615533002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp:12: //
TODO(sunjian): Move this logic into PerformanceBase
On 2017/01/04 20:54:30, panicker wrote:
> Let's remove the redundant one in ResourceTiming as well while we are at it:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/timing/Pe...

Done.

[sunjian, 2017-01-05 01:14:40]

Description was changed from

==========
Remove duplicate domHighResTimestamp conversion in NavigationTiming

BUG=676180
==========

to

==========
Remove duplicate domHighResTimestamp conversion in NavigationTiming and
ResourceTiming

BUG=676180
==========

[panicker, 2017-01-05 01:28:23]

panicker@chromium.org changed reviewers:
+ yoav@yoav.ws

[panicker, 2017-01-05 01:28:23]

LGTM.

[Yoav Weiss, 2017-01-06 11:40:07]

On 2017/01/05 01:28:23, panicker wrote:
> LGTM.

LGTM

[sunjian, 2017-01-06 20:32:14]

The CQ bit was checked by sunjian@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:33:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 22:18:20]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sunjian, 2017-01-07 01:01:34]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-07 01:01:34]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws,
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2615533002/#ps60001
(title: "sync")

[commit-bot: I haz the power, 2017-01-07 01:02:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 02:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:37:28]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yoav Weiss, 2017-01-07 04:05:27]

On 2017/01/07 02:37:28, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Test failures seem relevant

[sunjian, 2017-01-09 18:57:40]

You might want to take an extra pass at this.

[panicker, 2017-01-09 19:04:38]

On 2017/01/09 18:57:40, sunjian wrote:
> You might want to take an extra pass at this.

To be clear the issue was that existing implementation of
monotonicTimeToDOMHighResTimeStamp in PerformanceBase was not handling the case
for monotonicTime being 0.

[panicker, 2017-01-09 19:05:16]

LGTM

[sunjian, 2017-01-09 21:36:24]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-09 21:36:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws
Link to the patchset: https://codereview.chromium.org/2615533002/#ps80001
(title: "fixed layout test failures")

[commit-bot: I haz the power, 2017-01-09 21:37:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 22:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:45:51]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sunjian, 2017-01-09 23:33:48]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 23:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:45:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sunjian, 2017-01-10 01:03:17]

Patchset #4 (id:80001) has been deleted

[sunjian, 2017-01-10 01:03:59]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:04:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:06:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[sunjian, 2017-01-10 03:12:44]

The CQ bit was checked by sunjian@chromium.org

[sunjian, 2017-01-10 03:12:44]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws,
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2615533002/#ps100001
(title: "fixed layout test failures")

[commit-bot: I haz the power, 2017-01-10 03:13:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:42:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484017964044040,
"parent_rev": "b613df596c63e3e69b4addaaa676e54877b8f261", "commit_rev":
"f4fb16ccc801791db8d03b8f4cc8393fa36000fb"}

[commit-bot: I haz the power, 2017-01-10 04:42:41]

Description was changed from

==========
Remove duplicate domHighResTimestamp conversion in NavigationTiming and
ResourceTiming

BUG=676180
==========

to

==========
Remove duplicate domHighResTimestamp conversion in NavigationTiming and
ResourceTiming

BUG=676180

Review-Url: https://codereview.chromium.org/2615533002
Cr-Commit-Position: refs/heads/master@{#442474}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4fb16ccc801791db8d03b8f4cc8...
==========

[commit-bot: I haz the power, 2017-01-10 04:42:43]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/f4fb16ccc801791db8d03b8f4cc8...