Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: components/data_reduction_proxy/proto/pageload_metrics.proto

Issue 2615493002: Adding compressed bytes to DRP pingback (Closed)
Patch Set: moving to KB Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/proto/pageload_metrics.proto
diff --git a/components/data_reduction_proxy/proto/pageload_metrics.proto b/components/data_reduction_proxy/proto/pageload_metrics.proto
index cd9d1420b257f14a4008ccbede0afe2484091f05..764646a0f28dc4d27c5c8bcd710e72c73855f291 100644
--- a/components/data_reduction_proxy/proto/pageload_metrics.proto
+++ b/components/data_reduction_proxy/proto/pageload_metrics.proto
@@ -55,10 +55,10 @@ message PageloadMetrics {
// The sum of original-content-length values, over resources that were not
// loaded from browser cache.
- optional int32 original_page_size_bytes = 10;
+ optional int32 original_page_size_kb = 10;
tbansal1 2017/01/19 22:01:18 nitpicking: s/kb/kB/ https://en.wikipedia.org/wiki
RyanSturm 2017/01/19 22:11:34 Acknowledged. Contextually, this should be underst
tbansal1 2017/01/19 22:24:09 OK, I will leave up to you. There have been cases
RyanSturm 2017/01/25 22:14:45 obsolete
// The sum of (compressed) content-length, over resources that were not loaded
// from browser cache.
- optional int32 compressed_page_size_bytes = 11;
+ optional int32 compressed_page_size_kb = 11;
// The effective connection type at the start of the navigation.
optional EffectiveConnectionType effective_connection_type = 12;
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698