Forbid non-locals/keyed-property calls to allow interleaved compile.

Forbid non-locals/keyed-property calls to allow interleaved compile.

Deferred function call validation is required to support out of order
asm.js function declaration. Unfortunately, since we've started interleaving
validation and asm-wasm building, we don't check names are resolved until
the end.
Fortunately, undefined names can be detected from their CallType.
Check this at asm-typer time.

BUG=676797
R=aseemgarg@chromium.org,titzer@chromium.org

Review-Url: https://codereview.chromium.org/2615443003
Cr-Commit-Position: refs/heads/master@{#42158}
Committed: https://chromium.googlesource.com/v8/v8/+/be10e68f39b4697e56fcdfcd661dfdbcf19485b7

[bradnelson, 2017-01-03 20:23:53]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 20:24:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 20:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 20:37:03]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[aseemgarg, 2017-01-03 21:38:19]

lgtm

[titzer, 2017-01-09 09:04:25]

On 2017/01/03 21:38:19, aseemgarg wrote:
> lgtm

lgtm, looks like at least some of the failures are due to a different error
message now.

[bradnelson, 2017-01-10 03:41:54]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 03:42:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2017-01-10 03:52:25]

The CQ bit was unchecked by bradnelson@chromium.org

[bradnelson, 2017-01-10 03:52:26]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2017-01-10 03:52:26]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
aseemgarg@chromium.org
Link to the patchset: https://codereview.chromium.org/2615443003/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2017-01-10 03:52:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:07:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484020346515650,
"parent_rev": "0dde3045ad78d69ae63499256233e31849ecfd94", "commit_rev":
"be10e68f39b4697e56fcdfcd661dfdbcf19485b7"}

[commit-bot: I haz the power, 2017-01-10 04:07:20]

Description was changed from

==========
Forbid non-locals/keyed-property calls to allow interleaved compile.

Deferred function call validation is required to support out of order
asm.js function declaration. Unfortunately, since we've started interleaving
validation and asm-wasm building, we don't check names are resolved until
the end.
Fortunately, undefined names can be detected from their CallType.
Check this at asm-typer time.

BUG=676797
R=aseemgarg@chromium.org,titzer@chromium.org
==========

to

==========
Forbid non-locals/keyed-property calls to allow interleaved compile.

Deferred function call validation is required to support out of order
asm.js function declaration. Unfortunately, since we've started interleaving
validation and asm-wasm building, we don't check names are resolved until
the end.
Fortunately, undefined names can be detected from their CallType.
Check this at asm-typer time.

BUG=676797
R=aseemgarg@chromium.org,titzer@chromium.org

Review-Url: https://codereview.chromium.org/2615443003
Cr-Commit-Position: refs/heads/master@{#42158}
Committed:
https://chromium.googlesource.com/v8/v8/+/be10e68f39b4697e56fcdfcd661dfdbcf19...
==========

[commit-bot: I haz the power, 2017-01-10 04:07:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/be10e68f39b4697e56fcdfcd661dfdbcf19...