Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2615403002: Added extension controlled prefs to TestingPrefService (Closed)

Created:
3 years, 11 months ago by Alexander Yashkin
Modified:
3 years, 11 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, grt+watch_chromium.org, oshima+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added extension controlled prefs to TestingPrefService This CL is extracted from https://codereview.chromium.org/2479113002. to keep it under manageable size. This changes are helpful to emulate extension controlled prefs in unit_tests. R=gab@chromium.org Review-Url: https://codereview.chromium.org/2615403002 Cr-Commit-Position: refs/heads/master@{#442215} Committed: https://chromium.googlesource.com/chromium/src/+/658f626bbfc9e31ece0266453246a357a9de3735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -14 lines) Patch
M chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/prefs/testing_pref_service.h View 5 chunks +35 lines, -6 lines 0 comments Download
M components/prefs/testing_pref_service.cc View 4 chunks +4 lines, -1 line 0 comments Download
M components/sync_preferences/testing_pref_service_syncable.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/sync_preferences/testing_pref_service_syncable.cc View 5 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Alexander Yashkin
3 years, 11 months ago (2017-01-07 20:28:24 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-09 08:33:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615403002/1
3 years, 11 months ago (2017-01-09 09:15:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/658f626bbfc9e31ece0266453246a357a9de3735
3 years, 11 months ago (2017-01-09 09:19:19 UTC) #16
gab
3 years, 11 months ago (2017-01-09 17:01:08 UTC) #17
Message was sent while issue was closed.
prefs r-s per https://codereview.chromium.org/2479113002

Powered by Google App Engine
This is Rietveld 408576698