Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2615383002: Implement StringPieceHasSubstrMatcher. (Closed)

Created:
3 years, 11 months ago by Bence
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement StringPieceHasSubstrMatcher. This makes it possible to define a HasSubstr() that is compatible with base::StringPiece arguments, thus reducing divergence between upstream and Chromium code. (In the upstream codebase, base::StringPiece can be implicitly converted into std::string, so there is no need for this workaround.) Review-Url: https://codereview.chromium.org/2615383002 Cr-Commit-Position: refs/heads/master@{#442914} Committed: https://chromium.googlesource.com/chromium/src/+/e5cfe692b132aa62616a5db9f56e23621c4b9c9e

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -17 lines) Patch
M net/http2/hpack/decoder/hpack_whole_entry_buffer_test.cc View 6 chunks +15 lines, -17 lines 0 comments Download
M net/test/gtest_util.h View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Bence
Ryan: PTAL. Thank you.
3 years, 11 months ago (2017-01-08 01:16:50 UTC) #6
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-10 22:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615383002/20001
3 years, 11 months ago (2017-01-11 14:13:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98142)
3 years, 11 months ago (2017-01-11 15:26:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615383002/20001
3 years, 11 months ago (2017-01-11 16:02:21 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 16:07:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5cfe692b132aa62616a5db9f56e...

Powered by Google App Engine
This is Rietveld 408576698