Remove AudioBuffer::set_duration(), instead base on frames.

Remove AudioBuffer::set_duration(), instead base on frames.

wolenetz@ asked on https://codereview.chromium.org/251893002/ why
we allow set_duration() to be called.  It used to be required since
AudioBuffers had no concept of sample rate.  However, we now attach
a sample rate to every AudioBuffer which allows us to enforce a
valid duration for every buffer.

This CL also aligns MakeAudioBuffer() to do the same thing with
planar and interleaved data for the sake of easier testing.

BUG=none
TEST=media_unittests
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267779

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267842

[DaleCurtis, 2014-04-29 23:20:30]

Per comments on the other review, this could be removed w/ a bit of yak shaving.

[DaleCurtis, 2014-04-30 20:40:35]

Since wolenetz@ is out, over to jrummell@ who wrote most of this code.

[DaleCurtis, 2014-05-01 18:06:42]

+dmichael for parameter removal in
content/renderer/pepper/content_decryptor_delegate.cc

[dmichael (off chromium), 2014-05-01 19:59:46]

content/renderer/pepper lgtm

[wolenetz, 2014-05-01 20:18:24]

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer.h
File media/base/audio_buffer.h (right):

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer....
media/base/audio_buffer.h:38: // TODO(jrummell): Compute duration rather than
pass it in.
drive-by nit: remove this comment now?

[jrummell, 2014-05-01 20:26:25]

lgtm

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer.cc
File media/base/audio_buffer.cc (right):

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer....
media/base/audio_buffer.cc:35:
duration_(CalculateDuration(adjusted_frame_count_, sample_rate_)) {
nit: Would it be better to compute the duration only when needed? Code Search
isn't working for me right now, so I can't tell if duration() is referred to a
lot. Tests don't appear to check the duration very much.

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer.h
File media/base/audio_buffer.h (right):

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer....
media/base/audio_buffer.h:38: // TODO(jrummell): Compute duration rather than
pass it in.
nit: Can you remove this comment since it's done now :)

[DaleCurtis, 2014-05-01 20:33:18]

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer.cc
File media/base/audio_buffer.cc (right):

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer....
media/base/audio_buffer.cc:35:
duration_(CalculateDuration(adjusted_frame_count_, sample_rate_)) {
On 2014/05/01 20:26:26, jrummell wrote:
> nit: Would it be better to compute the duration only when needed? Code Search
> isn't working for me right now, so I can't tell if duration() is referred to a
> lot. Tests don't appear to check the duration very much.

It's cheap to calculate and I don't want to have to rename all the
hacker_style() duration() calls to GetDuration() :)

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer.h
File media/base/audio_buffer.h (right):

https://codereview.chromium.org/261533002/diff/60001/media/base/audio_buffer....
media/base/audio_buffer.h:38: // TODO(jrummell): Compute duration rather than
pass it in.
On 2014/05/01 20:26:26, jrummell wrote:
> nit: Can you remove this comment since it's done now :)

Done.

[DaleCurtis, 2014-05-01 20:33:28]

Thanks for review!

[DaleCurtis, 2014-05-01 20:33:32]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-05-01 20:33:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/261533002/70001

[commit-bot: I haz the power, 2014-05-02 00:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 00:15:18]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[DaleCurtis, 2014-05-02 04:25:00]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-05-02 04:25:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/261533002/70001

[DaleCurtis, 2014-05-02 04:47:19]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-05-02 04:47:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/261533002/90001

[commit-bot: I haz the power, 2014-05-02 09:55:54]

Change committed as 267779

[falken, 2014-05-02 10:50:29]

A revert of this CL has been created in
https://codereview.chromium.org/265943002/ by falken@chromium.org.

The reason for reverting is: This seems to have broken the chromium.webkit
WebKit Win x64 Builder bot.

Log:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bui...

Snippet from log:
c:\b\build\slave\webkit-win-latest-rel-x64\build\src\media\base\audio_buffer.cc(16)
: error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\webkit-win-latest-rel-x64\build\src\media\base\audio_buffer.cc(16)
: warning C4723: potential divide by 0.

[DaleCurtis, 2014-05-02 17:27:14]

Wow, that bot is smart, sadly not smart enough to tell me where, but in this
case the AudioBuffer::CreateEOSBuffer() was specifying a sample_rate of 0. 
Fixed and added a DCHECK()

[DaleCurtis, 2014-05-02 17:28:11]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-05-02 17:28:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/261533002/110001

[commit-bot: I haz the power, 2014-05-02 17:33:01]

Change committed as 267842