third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html - Issue 2615273002: Bump Bluetooth max filter name length from 29 bytes to 240 bytes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html

Issue 2615273002: Bump Bluetooth max filter name length from 29 bytes to 240 bytes (Closed)

Patch Set: Expand max length comments and add spec citation Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/bluetooth/bluetooth_device_chooser_controller.cc ('K') | « content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('k') | third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-for-name-in-adv-name.html » ('j') | third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html

new file mode 100644

index 0000000000000000000000000000000000000000..bce10dd827ead5536bc13ed7608e66420fae8fdc

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html

@@ -0,0 +1,15 @@

+<!DOCTYPE html>

+<script src="../../../resources/testharness.js"></script>

+<script src="../../../resources/testharnessreport.js"></script>

+<script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

+'use strict';

+promise_test(() => {

+ const name = 'a_device_name_that_is_longer_than_29_bytes_but_shorter_than_240_bytes'

+ return setBluetoothFakeAdapter('DeviceNameLongerThan29BytesAdapter')

+ .then(() => requestDeviceWithKeyDown({

+ filters: [{name: name}]}))

+ .then(device => assert_equals(device.name, 'rutabaga'));

+}, 'A device name between 29 and 240 bytes is valid.');

+</script>

jeffcarp 2017/01/11 01:47:27 Got the new layout test working. lmk if this works