Chromium Code Reviews| Index: content/browser/bluetooth/bluetooth_device_chooser_controller.cc |
| diff --git a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc |
| index 19cad9b7c8ea02382046bf52fcc3db903a22a406..090df58aa6035fe10718573ea765619b3bde7b83 100644 |
| --- a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc |
| +++ b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc |
| @@ -79,8 +79,11 @@ namespace content { |
| bool BluetoothDeviceChooserController::use_test_scan_duration_ = false; |
| namespace { |
| -constexpr size_t kMaxLengthForDeviceName = |
| - 29; // max length of device name in filter. |
| +// Max length of device name in filter. A name coming from an adv packet |
| +// is max 29 bytes (adv packet max size 31 bytes - 2 byte length field), |
| +// but the name can also be acquired via gap.device_name, so it is limited |
| +// to the max EIR packet size of 240 bytes. See Core Spec 5.0, vol 3, C, 8.1.2. |
|
jeffcarp
2017/01/11 01:47:27
Added spec citation here and copied over the comme
|
| +constexpr size_t kMaxLengthForDeviceName = 240; |
| // The duration of a Bluetooth Scan in seconds. |
| constexpr int kScanDuration = 60; |