third_party/WebKit/LayoutTests/bluetooth/requestDevice/device-name-longer-than-29-bytes.html - Issue 2615273002: Bump Bluetooth max filter name length from 29 bytes to 240 bytes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/device-name-longer-than-29-bytes.html

Issue 2615273002: Bump Bluetooth max filter name length from 29 bytes to 240 bytes (Closed)

Patch Set: Fix layout tests, begin to add new layout test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/bluetooth/bluetooth_device_chooser_controller.cc ('K') | « third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-namePrefix.html ('k') | third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp » ('j') | third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice/device-name-longer-than-29-bytes.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/device-name-longer-than-29-bytes.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/device-name-longer-than-29-bytes.html

new file mode 100644

index 0000000000000000000000000000000000000000..ccde915c14db03377524568a3fb523169f94861c

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/device-name-longer-than-29-bytes.html

@@ -0,0 +1,13 @@

+<!DOCTYPE html>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

+<script>

+'use strict';

+promise_test(() => {

+ return setBluetoothFakeAdapter('DeviceNameLongerThan29BytesAdapter')

+ .then(() => requestDeviceWithKeyDown({

+ filters: [{services: ['a_device_name_that_is_longer_than_29_bytes_but_shorter_than_240_bytes']}]}))

+ .then(device => assert_equals(device.name, 'Glucose Device'));

+}, 'Simple filter selects matching device.');

+</script>