Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2615153002: Remove ContextClient from NavigatorDoNotTrack (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from NavigatorDoNotTrack Now that Navigator's suppelemnt can access the Navigator object via host(), it doesn't need to observe ContextClient. BUG=610176 Review-Url: https://codereview.chromium.org/2615153002 Cr-Commit-Position: refs/heads/master@{#441890} Committed: https://chromium.googlesource.com/chromium/src/+/e12c3a936186cf3d3f9e388ae2be6a484e40096e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 01:25:22 UTC) #2
sof
lgtm
3 years, 11 months ago (2017-01-06 06:17:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615153002/1
3 years, 11 months ago (2017-01-06 06:25:45 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 06:30:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e12c3a936186cf3d3f9e388ae2be...

Powered by Google App Engine
This is Rietveld 408576698