CSS Transitions: fix flaky cancel-transition.html

CSS Transitions: fix flaky cancel-transition.html

We no longer rely on setTimeout timing.


BUG=248938
Review-Url: https://codereview.chromium.org/2615123002
Cr-Commit-Position: refs/heads/master@{#441883}
Committed: https://chromium.googlesource.com/chromium/src/+/34e9fa074784389762eab891850c78371622d216

[Eric Willigers, 2017-01-06 00:02:45]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2017-01-06 00:02:53]

ericwilligers@chromium.org changed reviewers:
+ suzyh@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[suzyh_UTC10 (ex-contributor), 2017-01-06 00:14:07]

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/cancel-transition.html (right):

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:39: If working
properly the transitions should start from the beginning. But there was a bug
that
Reference bug number, if you can find it.

Not sure whether this belongs as a <p> rather than a comment but since this is
how it was, I'm not fussed about leaving it as-is.

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:49: function
wait() {
Please give this a more descriptive name than 'wait'.

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:56:
getComputedStyle(container).height; // force transition start
Nit: Reword as "force style recalc - transition will start". Similarly below.

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:58:
container.className = '';
Perhaps before cancelling the transition here, we need to assert that it has
progressed past the first frame. Otherwise, passing the assertions below might
be spurious. WDYT?

[commit-bot: I haz the power, 2017-01-06 01:36:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 01:36:04]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2017-01-06 01:39:02]

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/transitions/cancel-transition.html (right):

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:39: If working
properly the transitions should start from the beginning. But there was a bug
that
On 2017/01/06 00:14:07, suzyh wrote:
> Reference bug number, if you can find it.
> 
> Not sure whether this belongs as a <p> rather than a comment but since this is
> how it was, I'm not fussed about leaving it as-is.

Done.

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:49: function
wait() {
On 2017/01/06 00:14:07, suzyh wrote:
> Please give this a more descriptive name than 'wait'.

Done.

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:56:
getComputedStyle(container).height; // force transition start
On 2017/01/06 00:14:07, suzyh wrote:
> Nit: Reword as "force style recalc - transition will start". Similarly below.

Done.

https://codereview.chromium.org/2615123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/transitions/cancel-transition.html:58:
container.className = '';
On 2017/01/06 00:14:07, suzyh wrote:
> Perhaps before cancelling the transition here, we need to assert that it has
> progressed past the first frame. Otherwise, passing the assertions below might
> be spurious. WDYT?

Done.

[suzyh_UTC10 (ex-contributor), 2017-01-06 03:14:18]

lgtm

[Eric Willigers, 2017-01-06 03:18:48]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:19:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-01-06 04:19:08]

The CQ bit was unchecked by ericwilligers@chromium.org

[Eric Willigers, 2017-01-06 04:22:23]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2017-01-06 04:22:23]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2615123002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-06 04:22:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 05:50:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483676543017050,
"parent_rev": "b47d881a6fb62661e9e4319d2a693897835c8acc", "commit_rev":
"34e9fa074784389762eab891850c78371622d216"}

[commit-bot: I haz the power, 2017-01-06 05:51:09]

Description was changed from

==========
CSS Transitions: fix flaky cancel-transition.html

We no longer rely on setTimeout timing.


BUG=248938
==========

to

==========
CSS Transitions: fix flaky cancel-transition.html

We no longer rely on setTimeout timing.


BUG=248938

Review-Url: https://codereview.chromium.org/2615123002
Cr-Commit-Position: refs/heads/master@{#441883}
Committed:
https://chromium.googlesource.com/chromium/src/+/34e9fa074784389762eab891850c...
==========

[commit-bot: I haz the power, 2017-01-06 05:51:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/34e9fa074784389762eab891850c...