Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2615103002: Revert of Roll WebRTC 15911:15919 (5 commits) (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll WebRTC 15911:15919 (5 commits) (patchset #1 id:1 of https://codereview.chromium.org/2617693003/ ) Reason for revert: Revert in hopes of fixing linux x64. If doesn't fix it will revert revert http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/15545 Original issue's description: > Roll WebRTC 15911:15919 (5 commits) > > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/af5a0a0..5445b07 > > $ git log af5a0a0..5445b07 --date=short --no-merges --format=%ad %ae %s > 2017-01-05 ehmaldonado@webrtc.org Reland of actor webrtc_perf_tests into several source_sets. (patchset #1 id:1 of https://codereview.webrtc.org/2613913002/ ) > 2017-01-05 ehmaldonado@webrtc.org GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package boundaries. > 2017-01-05 danilchap@webrtc.org Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ ) > 2017-01-05 mbonadei@webrtc.org Revert of Fixing package-boundary violation with srjar_deps (patchset #5 id:80001 of https://codereview.webrtc.org/2610823002/ ) > 2017-01-05 mbonadei@webrtc.org Fixing package-boundary violation with srjar_deps > > TBR= > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > BUG= > > Review-Url: https://codereview.chromium.org/2617693003 > Cr-Commit-Position: refs/heads/master@{#441751} > Committed: https://chromium.googlesource.com/chromium/src/+/01b8456652e46cc732b7d9282f07fca6e4c99d00 TBR=perkj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2615103002 Cr-Commit-Position: refs/heads/master@{#441774} Committed: https://chromium.googlesource.com/chromium/src/+/a671e274dc99a9e9737a241e228ee624e44aef01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
Created Revert of Roll WebRTC 15911:15919 (5 commits)
3 years, 11 months ago (2017-01-05 22:32:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615103002/1
3 years, 11 months ago (2017-01-05 22:33:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a671e274dc99a9e9737a241e228ee624e44aef01
3 years, 11 months ago (2017-01-05 22:34:55 UTC) #6
sky
On 2017/01/05 22:34:55, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-06 00:06:12 UTC) #7
sky
3 years, 11 months ago (2017-01-06 01:01:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2614773005/ by sky@chromium.org.

The reason for reverting is: Original patch didn't break build. It was
https://codereview.chromium.org/2611153002/ ..

Powered by Google App Engine
This is Rietveld 408576698