Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2615093004: [ios] Made TestWebStateDelegate and TestJavaScriptDialogPresenter reusable. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
Reviewers:
michaeldo
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Made TestWebStateDelegate and TestJavaScriptDialogPresenter reusable. These fakes will be resued in CRWWebControllerPageDialogOpenPolicyTest instead of CRWWebUserInterfaceDelegate mock. BUG=661445 TRR=kkhorimoto@chromium.org Review-Url: https://codereview.chromium.org/2615093004 Cr-Commit-Position: refs/heads/master@{#441991} Committed: https://chromium.googlesource.com/chromium/src/+/4b8c72978c833f414ea4c6e00ddd128601e8f284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -97 lines) Patch
M ios/web/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
A ios/web/public/test/fakes/test_java_script_dialog_presenter.h View 1 chunk +70 lines, -0 lines 0 comments Download
A ios/web/public/test/fakes/test_java_script_dialog_presenter.mm View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/web/public/test/fakes/test_web_state_delegate.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/web/public/test/fakes/test_web_state_delegate.mm View 1 chunk +30 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 4 chunks +8 lines, -97 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-06 00:25:46 UTC) #2
michaeldo
On 2017/01/06 00:25:46, Eugene But wrote: lgtm
3 years, 11 months ago (2017-01-06 18:18:17 UTC) #7
Eugene But (OOO till 7-30)
Thanks!
3 years, 11 months ago (2017-01-06 18:37:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615093004/1
3 years, 11 months ago (2017-01-06 18:38:08 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:43:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b8c72978c833f414ea4c6e00ddd...

Powered by Google App Engine
This is Rietveld 408576698