MD Settings: add <controlled-button>#endJustified to flip controlled by indicator position

MD Settings: add <controlled-button>#endJustified to flip controlled by indicator position

BUG=673953
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615093003
Cr-Commit-Position: refs/heads/master@{#442346}
Committed: https://chromium.googlesource.com/chromium/src/+/0649171aca96b82408f54611cd76bea80eee3ad2

[Dan Beam, 2017-01-05 23:26:48]

Description was changed from

==========
MD Settings: add <controlled-button>#endJustified to flip controlled by
indicator position

BUG=673953
R=dschuyler@chromium.org
==========

to

==========
MD Settings: add <controlled-button>#endJustified to flip controlled by
indicator position

BUG=673953
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-06 00:39:58]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 00:40:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-01-06 00:43:17]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 00:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 01:53:57]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-01-07 00:47:45]

ping

[dschuyler, 2017-01-07 02:12:20]

lgtm

https://codereview.chromium.org/2615093003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.html (right):

https://codereview.chromium.org/2615093003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.html:36: order: -1;
I'm not familiar with order: -1 to be sure it's correct.

[Dan Beam, 2017-01-07 02:14:18]

https://codereview.chromium.org/2615093003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/controlled_button.html (right):

https://codereview.chromium.org/2615093003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/controlled_button.html:36: order: -1;
On 2017/01/07 02:12:20, dschuyler wrote:
> I'm not familiar with order: -1 to be sure it's correct.

trust me, it's magical

[Dan Beam, 2017-01-07 02:14:23]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:14:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 03:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 03:04:03]

Failed to apply patch for
chrome/browser/resources/settings/controls/controlled_button.js:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/settings/controls/controlled_button.js:8
  error: chrome/browser/resources/settings/controls/controlled_button.js: patch
does not apply

Patch:       chrome/browser/resources/settings/controls/controlled_button.js
Index: chrome/browser/resources/settings/controls/controlled_button.js
diff --git a/chrome/browser/resources/settings/controls/controlled_button.js
b/chrome/browser/resources/settings/controls/controlled_button.js
index
ac4428f338322d6b5c40e0ba7060bb574b79d2af..23586c064791b1607c6acdc21e05bdeae1294a26
100644
--- a/chrome/browser/resources/settings/controls/controlled_button.js
+++ b/chrome/browser/resources/settings/controls/controlled_button.js
@@ -8,6 +8,12 @@ Polymer({
   behaviors: [CrPolicyPrefBehavior, PrefControlBehavior],
 
   properties: {
+    endJustified: {
+      type: Boolean,
+      value: false,
+      reflectToAttribute: true,
+    },
+
     /** @private */
     controlled_: {
       type: Boolean,

[Dan Beam, 2017-01-09 19:56:48]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-09 19:56:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2615093003/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-01-09 19:57:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:15:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483991808731580,
"parent_rev": "ab773ceb4a76cbad58863b2ad67c25b8c749eeeb", "commit_rev":
"0649171aca96b82408f54611cd76bea80eee3ad2"}

[commit-bot: I haz the power, 2017-01-09 21:15:39]

Description was changed from

==========
MD Settings: add <controlled-button>#endJustified to flip controlled by
indicator position

BUG=673953
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: add <controlled-button>#endJustified to flip controlled by
indicator position

BUG=673953
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615093003
Cr-Commit-Position: refs/heads/master@{#442346}
Committed:
https://chromium.googlesource.com/chromium/src/+/0649171aca96b82408f54611cd76...
==========

[commit-bot: I haz the power, 2017-01-09 21:15:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0649171aca96b82408f54611cd76...