Typemap WebBluetoothDeviceId to WTF::String

Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String.
2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.
3. Use mojom::blink::WebBluetoothDevicePtr directly in the parameter.
4. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.

BUG=676702, 597053
Review-Url: https://codereview.chromium.org/2615093002
Cr-Commit-Position: refs/heads/master@{#442397}
Committed: https://chromium.googlesource.com/chromium/src/+/8819858e6747aae06f155f04909b458ee782538c

[juncai, 2017-01-05 21:42:23]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:43:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-01-05 21:43:19]

Description was changed from

==========
Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String
2. Use WebBluetoothRemoteGATTCharacteristic blink struct directly
3.

BUG=676702, 597053
==========

to

==========
Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String
2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the parameter.
3.

BUG=676702, 597053
==========

[juncai, 2017-01-05 21:46:23]

Description was changed from

==========
Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String
2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the parameter.
3.

BUG=676702, 597053
==========

to

==========
Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String.
2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.
3. Use mojom::blink::WebBluetoothDevicePtr directly in the parameter.
4. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.

BUG=676702, 597053
==========

[juncai, 2017-01-05 22:00:11]

juncai@chromium.org changed reviewers:
+ dcheng@chromium.org, scheib@chromium.org

[juncai, 2017-01-05 22:00:11]

scheib@chromium.org: Please review changes in
//third_party/WebKit/Source/modules/bluetooth

dcheng@chromium.org: Please review changes in
//third_party/WebKit/Source/platform/mojo

[commit-bot: I haz the power, 2017-01-05 23:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:58:23]

Dry run: This issue passed the CQ dry run.

[scheib, 2017-01-07 01:25:53]

LGTM, minor suggestions:

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:239: 
nit: avoid whitespace changes

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:291:
mojom::blink::WebBluetoothDevicePtr device,
I recommend renaming the parameter 'device_ptr' and below using just 'device'
for the BluetoothDevice.

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/mojo/Bluetooth.typemap (right):

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/mojo/Bluetooth.typemap:4: 
maybe try this in 
third_party/WebKit/public/platform/modules/bluetooth/

[juncai, 2017-01-09 19:06:17]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:06:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:09:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:09:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[juncai, 2017-01-09 19:20:28]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:21:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:24:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:24:06]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dcheng, 2017-01-09 20:02:04]

mojo lgtm

[juncai, 2017-01-09 20:02:54]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 20:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2017-01-09 20:25:50]

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp (right):

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:239: 
On 2017/01/07 01:25:53, scheib wrote:
> nit: avoid whitespace changes

Done.

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp:291:
mojom::blink::WebBluetoothDevicePtr device,
On 2017/01/07 01:25:53, scheib wrote:
> I recommend renaming the parameter 'device_ptr' and below using just 'device'
> for the BluetoothDevice.

Done.

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/mojo/Bluetooth.typemap (right):

https://codereview.chromium.org/2615093002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/mojo/Bluetooth.typemap:4: 
On 2017/01/07 01:25:53, scheib wrote:
> maybe try this in 
> third_party/WebKit/public/platform/modules/bluetooth/

Done.

[commit-bot: I haz the power, 2017-01-09 22:37:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 22:37:36]

Dry run: This issue passed the CQ dry run.

[juncai, 2017-01-09 22:39:42]

The CQ bit was checked by juncai@chromium.org

[juncai, 2017-01-09 22:39:42]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2615093002/#ps60001
(title: "merge master")

[commit-bot: I haz the power, 2017-01-09 22:40:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:16:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484001582029100,
"parent_rev": "ed9dda4b653e8176e3ff039776d269662280cd4c", "commit_rev":
"8819858e6747aae06f155f04909b458ee782538c"}

[commit-bot: I haz the power, 2017-01-09 23:17:25]

Description was changed from

==========
Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String.
2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.
3. Use mojom::blink::WebBluetoothDevicePtr directly in the parameter.
4. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.

BUG=676702, 597053
==========

to

==========
Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String.
2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.
3. Use mojom::blink::WebBluetoothDevicePtr directly in the parameter.
4. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.

BUG=676702, 597053

Review-Url: https://codereview.chromium.org/2615093002
Cr-Commit-Position: refs/heads/master@{#442397}
Committed:
https://chromium.googlesource.com/chromium/src/+/8819858e6747aae06f155f04909b...
==========

[commit-bot: I haz the power, 2017-01-09 23:17:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8819858e6747aae06f155f04909b...