DevTools: setImmediate polyfill should handle arguments

DevTools: setImmediate polyfill should handle arguments

BUG=678722
Review-Url: https://codereview.chromium.org/2615083002
Cr-Commit-Position: refs/heads/master@{#442049}
Committed: https://chromium.googlesource.com/chromium/src/+/901cf165f79e89e6e041cc413e1b47e20a8fe898

[paulirish, 2017-01-05 20:12:23]

paulirish@chromium.org changed reviewers:
+ pfeldman@chromium.org

[paulirish, 2017-01-05 20:12:24]

PTAL

[paulirish, 2017-01-05 20:13:49]

The CQ bit was checked by paulirish@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 20:14:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 21:29:40]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[pfeldman, 2017-01-06 00:08:51]

lgtm

https://codereview.chromium.org/2615083002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/platform/utilities.js (right):

https://codereview.chromium.org/2615083002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/platform/utilities.js:1371:
Promise.resolve().then(_ => callback(...args));
nit: () =>

[paulirish, 2017-01-06 18:53:45]

The CQ bit was checked by paulirish@chromium.org

[paulirish, 2017-01-06 18:53:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2615083002/#ps20001
(title: "_ => ()")

[commit-bot: I haz the power, 2017-01-06 18:54:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:06:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483728825590130,
"parent_rev": "db2df0adddb5ab717ecbdc1c57e1e7aa958908da", "commit_rev":
"901cf165f79e89e6e041cc413e1b47e20a8fe898"}

[commit-bot: I haz the power, 2017-01-06 21:07:13]

Description was changed from

==========
DevTools: setImmediate polyfill should handle arguments

BUG=678722
==========

to

==========
DevTools: setImmediate polyfill should handle arguments

BUG=678722

Review-Url: https://codereview.chromium.org/2615083002
Cr-Commit-Position: refs/heads/master@{#442049}
Committed:
https://chromium.googlesource.com/chromium/src/+/901cf165f79e89e6e041cc413e1b...
==========

[commit-bot: I haz the power, 2017-01-06 21:07:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/901cf165f79e89e6e041cc413e1b...

[PhistucK, 2017-01-07 11:29:29]

phistuck@gmail.com changed reviewers:
+ phistuck@gmail.com

[PhistucK, 2017-01-07 11:29:29]

Also, why not switch to requestIdleCallback?

https://codereview.chromium.org/2615083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/platform/utilities.js (right):

https://codereview.chromium.org/2615083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/platform/utilities.js:1369:
self.setImmediate = function(callback) {
Why not callback, ...args?
It removes the need for slice afterwards.

[pfeldman, 2017-01-09 22:05:05]

setImmediate and requestIdleCallback have different semantics.