PaymentApp: Add interfaces for implementing InvokePaymentApp().

PaymentApp: Add interfaces for implementing InvokePaymentApp().

This CL adds basic interfaces(including mojom) in renderer and browser in order
to implement InvokePaymentApp(). The interfaces will actually be implemented in
https://crrev.com/2610163002.

BUG=661608
Review-Url: https://codereview.chromium.org/2615063002
Cr-Commit-Position: refs/heads/master@{#442515}
Committed: https://chromium.googlesource.com/chromium/src/+/1cc5c53cff510fe6ba8b256603a01012bd68ba9d

[zino, 2017-01-05 20:05:18]

Description was changed from

==========
PaymentApp: Add interfaces for implementing InvokePaymentApp().

BUG=
==========

to

==========
PaymentApp: Add interfaces for implementing InvokePaymentApp().

This CL adds basic interfaces(including mojom) in renderer and browser in order
to implement InvokePaymentApp(). The interfaces will actually be implemented in
https://crrev.com/2610163002.

BUG=661608
==========

[zino, 2017-01-05 20:05:18]

jinho.bang@samsung.com changed reviewers:
+ avi@chromium.org, rouslan@chromium.org, tsepez@chromium.org

[zino, 2017-01-05 20:06:02]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 20:06:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 20:11:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:11:06]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Tom Sepez, 2017-01-05 21:02:37]

mojom lgtm

[zino, 2017-01-06 02:20:26]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 02:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 03:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:04:25]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[zino, 2017-01-06 10:44:50]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 10:45:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 11:52:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 11:52:05]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[zino, 2017-01-08 18:28:01]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-08 18:28:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-08 19:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-08 19:47:30]

Dry run: This issue passed the CQ dry run.

[zino, 2017-01-09 01:50:09]

PTAL

[Avi (use Gerrit), 2017-01-09 04:03:26]

lgtm

[please use gerrit instead, 2017-01-09 14:42:12]

lgtm % comments

https://codereview.chromium.org/2615063002/diff/100001/components/payments/pa...
File components/payments/payment_app.mojom (right):

https://codereview.chromium.org/2615063002/diff/100001/components/payments/pa...
components/payments/payment_app.mojom:38: string origin;
Can you make this a "Url" type? You would need to import the mojom file where
that's defined.

https://codereview.chromium.org/2615063002/diff/100001/content/browser/paymen...
File content/browser/payments/payment_app_provider_impl.cc (right):

https://codereview.chromium.org/2615063002/diff/100001/content/browser/paymen...
content/browser/payments/payment_app_provider_impl.cc:64: void
PaymentAppProviderImpl::InvokePaymentApp(
Needs to be under GetAllManifests() to keep the order in this file the same as
in the header file.

[zino, 2017-01-09 18:06:14]

Thank you for review.

https://codereview.chromium.org/2615063002/diff/100001/components/payments/pa...
File components/payments/payment_app.mojom (right):

https://codereview.chromium.org/2615063002/diff/100001/components/payments/pa...
components/payments/payment_app.mojom:38: string origin;
On 2017/01/09 14:42:12, rouslan wrote:
> Can you make this a "Url" type? You would need to import the mojom file where
> that's defined.

Done.

https://codereview.chromium.org/2615063002/diff/100001/content/browser/paymen...
File content/browser/payments/payment_app_provider_impl.cc (right):

https://codereview.chromium.org/2615063002/diff/100001/content/browser/paymen...
content/browser/payments/payment_app_provider_impl.cc:64: void
PaymentAppProviderImpl::InvokePaymentApp(
On 2017/01/09 14:42:12, rouslan wrote:
> Needs to be under GetAllManifests() to keep the order in this file the same as
> in the header file.

When I wrote this code at first time, I kept the order. But it seems to be
broken at rebase time.
Sorry for my repeated mistake.

Done.

[zino, 2017-01-10 02:39:30]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2017-01-10 02:39:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rouslan@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2615063002/#ps120001
(title: "PaymentApp: Add interfaces for implementing InvokePaymentApp().")

[commit-bot: I haz the power, 2017-01-10 02:40:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:16:32]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484015970221750,
"parent_rev": "eb5e40651ca7d137d9b4840a61ce050b5ac04f12", "commit_rev":
"1cc5c53cff510fe6ba8b256603a01012bd68ba9d"}

[commit-bot: I haz the power, 2017-01-10 06:17:03]

Description was changed from

==========
PaymentApp: Add interfaces for implementing InvokePaymentApp().

This CL adds basic interfaces(including mojom) in renderer and browser in order
to implement InvokePaymentApp(). The interfaces will actually be implemented in
https://crrev.com/2610163002.

BUG=661608
==========

to

==========
PaymentApp: Add interfaces for implementing InvokePaymentApp().

This CL adds basic interfaces(including mojom) in renderer and browser in order
to implement InvokePaymentApp(). The interfaces will actually be implemented in
https://crrev.com/2610163002.

BUG=661608

Review-Url: https://codereview.chromium.org/2615063002
Cr-Commit-Position: refs/heads/master@{#442515}
Committed:
https://chromium.googlesource.com/chromium/src/+/1cc5c53cff510fe6ba8b256603a0...
==========

[commit-bot: I haz the power, 2017-01-10 06:17:05]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/1cc5c53cff510fe6ba8b256603a0...