Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2615013002: gzip VR Shell's UI resources (Closed)

Created:
3 years, 11 months ago by mthiesse
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, feature-vr-reviews_chromium.org, cjgrant, klausw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gzip VR Shell's UI resources This saves ~21.6KB on debug component build, numbers should be similar for other builds. BUG=678636 Review-Url: https://codereview.chromium.org/2615013002 Cr-Commit-Position: refs/heads/master@{#441708} Committed: https://chromium.googlesource.com/chromium/src/+/37c901bbcb0f7480ab31d927051289ee613a72fd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mthiesse
PTAL
3 years, 11 months ago (2017-01-05 17:03:00 UTC) #2
Dan Beam
yay! lgtm https://codereview.chromium.org/2615013002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right): https://codereview.chromium.org/2615013002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc#newcode187 chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:187: source->UseGzip(excluded_paths); source->UseGzip(std::unordered_set<std::string>()); OR source->UseGzip(std::unordered_set<std::string>() /* excluded_paths */); ...
3 years, 11 months ago (2017-01-05 17:22:18 UTC) #3
mthiesse
https://codereview.chromium.org/2615013002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc File chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc (right): https://codereview.chromium.org/2615013002/diff/1/chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc#newcode187 chrome/browser/ui/webui/vr_shell/vr_shell_ui_ui.cc:187: source->UseGzip(excluded_paths); On 2017/01/05 17:22:17, Dan Beam wrote: > source->UseGzip(std::unordered_set<std::string>()); ...
3 years, 11 months ago (2017-01-05 17:25:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615013002/20001
3 years, 11 months ago (2017-01-05 17:26:02 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:38:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37c901bbcb0f7480ab31d9270512...

Powered by Google App Engine
This is Rietveld 408576698