Support showing loading progress in the VR omnibox.

Support showing loading progress in the VR omnibox.

- This change renders a partial blue border around the omnibox, according
  to page load state. When loading completes, the blue disappears.
- Remove CSS-based movement of the box; this will move to native
  animation.
- This change depends on a change to WebContentsObserver to pull the
  load status.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615003004
Cr-Commit-Position: refs/heads/master@{#442631}
Committed: https://chromium.googlesource.com/chromium/src/+/7a3be238572ce97fd3de4cdc93b9f2df16ff32ba

[cjgrant, 2017-01-06 17:35:32]

Description was changed from

==========
Support showing loading progress in the VR omnibox.

- This change renders a partial blue border around the omnibox, according
  to page load state. When loading completes, the blue disappears.
- Remove CSS-based movement of the box; this will move to native
  animation.
- This change depends on a change to WebContentsObserver to pull the
  load status.

BUG=641508
==========

to

==========
Support showing loading progress in the VR omnibox.

- This change renders a partial blue border around the omnibox, according
  to page load state. When loading completes, the blue disappears.
- Remove CSS-based movement of the box; this will move to native
  animation.
- This change depends on a change to WebContentsObserver to pull the
  load status.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2017-01-06 17:36:02]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, mthiesse@chromium.org

[mthiesse, 2017-01-06 21:11:18]

lgtm % comments

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.css (left):

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.css:126: height: 164px;
these were added when the omnibox wasn't permanent, in order to avoid elements
shifting and causing issues with the texture. Is that not a concern anymore?
We're never hiding the omnibox?

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.css (right):

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.css:147: height: 104x;
s/x/px?

[cjgrant, 2017-01-09 15:44:14]

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.css (left):

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.css:126: height: 164px;
On 2017/01/06 21:11:18, mthiesse wrote:
> these were added when the omnibox wasn't permanent, in order to avoid elements
> shifting and causing issues with the texture. Is that not a concern anymore?
> We're never hiding the omnibox?

The size is determined by #omnibox now, even if it's transparent.

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.css (right):

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.css:147: height: 104x;
On 2017/01/06 21:11:18, mthiesse wrote:
> s/x/px?

Agreed.

[bshe, 2017-01-09 22:14:28]

lgtm

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:414: let gradient =
'-webkit-linear-gradient(left, ' + this.statusBarColor +
nit: I believe we want to avoid using webkit prefix if possible, so perhaps use
linear-gradient(to right, ...)

[cjgrant, 2017-01-10 15:42:10]

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.css (right):

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.css:147: height: 104x;
On 2017/01/09 15:44:14, cjgrant wrote:
> On 2017/01/06 21:11:18, mthiesse wrote:
> > s/x/px?
> 
> Agreed.

Done.

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2615003004/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:414: let gradient =
'-webkit-linear-gradient(left, ' + this.statusBarColor +
On 2017/01/09 22:14:28, bshe wrote:
> nit: I believe we want to avoid using webkit prefix if possible, so perhaps
use
> linear-gradient(to right, ...)

Done. Good call.

[cjgrant, 2017-01-10 15:44:21]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-01-10 15:44:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2615003004/#ps20001
(title: "Address nits.")

[commit-bot: I haz the power, 2017-01-10 15:44:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 18:13:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484063061078680,
"parent_rev": "37b1f870e64e475e96f4d05580b5f2fd4fcf4665", "commit_rev":
"7a3be238572ce97fd3de4cdc93b9f2df16ff32ba"}

[commit-bot: I haz the power, 2017-01-10 18:14:01]

Description was changed from

==========
Support showing loading progress in the VR omnibox.

- This change renders a partial blue border around the omnibox, according
  to page load state. When loading completes, the blue disappears.
- Remove CSS-based movement of the box; this will move to native
  animation.
- This change depends on a change to WebContentsObserver to pull the
  load status.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support showing loading progress in the VR omnibox.

- This change renders a partial blue border around the omnibox, according
  to page load state. When loading completes, the blue disappears.
- Remove CSS-based movement of the box; this will move to native
  animation.
- This change depends on a change to WebContentsObserver to pull the
  load status.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615003004
Cr-Commit-Position: refs/heads/master@{#442631}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a3be238572ce97fd3de4cdc93b9...
==========

[commit-bot: I haz the power, 2017-01-10 18:14:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a3be238572ce97fd3de4cdc93b9...