Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2614983002: Add v8_enable_verify_predictable gn args (mirroring the gyp var) (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add v8_enable_verify_predictable gn args (mirroring the gyp var) R=machenbach@chromium.org BUG=chromium:645890 Review-Url: https://codereview.chromium.org/2614983002 Cr-Commit-Position: refs/heads/master@{#42093} Committed: https://chromium.googlesource.com/v8/v8/+/12d20bdd31b2856e3c6d25dc3388373e7fe6fd00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-05 14:29:47 UTC) #1
Michael Achenbach
lgtm, thanks! Maybe reference http://crbug.com/645890
3 years, 11 months ago (2017-01-05 14:54:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614983002/1
3 years, 11 months ago (2017-01-05 14:59:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 15:01:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/12d20bdd31b2856e3c6d25dc3388373e7fe...

Powered by Google App Engine
This is Rietveld 408576698