Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2614973003: [cleanup] Refactor builtins-string.cc to use TF_BUILTIN macro (Closed)

Created:
3 years, 11 months ago by Jakob Kummerow
Modified:
3 years, 11 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Refactor builtins-string.cc to use TF_BUILTIN macro Review-Url: https://codereview.chromium.org/2614973003 Cr-Commit-Position: refs/heads/master@{#42134} Committed: https://chromium.googlesource.com/v8/v8/+/f91e12cc0993ab0468a3714565cad7869a1062ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -734 lines) Patch
M src/builtins/builtins-string.cc View 8 chunks +527 lines, -734 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
PTAL. This is mostly mechanical (s/assembler->// etc.); I've also dropped a few unnecessary labels. No ...
3 years, 11 months ago (2017-01-05 14:52:09 UTC) #2
jgruber
lgtm. So much nicer without all the 'assembler.' noise.
3 years, 11 months ago (2017-01-09 09:44:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614973003/1
3 years, 11 months ago (2017-01-09 10:17:36 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 10:19:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f91e12cc0993ab0468a3714565cad7869a1...

Powered by Google App Engine
This is Rietveld 408576698