Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2614913002:
Remove additional uses of UseSubframeNavigationEntries in tests. (Closed)
|
Created:
3 years, 11 months ago by Charlie Reis Modified:
3 years, 11 months ago Reviewers:
nasko CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove additional uses of UseSubframeNavigationEntries in tests.
There's no longer a PageState mismatch from bug 617239, so we can
re-enable the test expectations for these tests.
BUG=236848, 617239
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2614913002
Cr-Commit-Position: refs/heads/master@{#441854}
Committed: https://chromium.googlesource.com/chromium/src/+/ebfd33fdbbe2b78234fd30c6fdbddfc3d162e06d
Patch Set 1 #Patch Set 2 : Postpone bug 618100 changes #
Total comments: 1
Messages
Total messages: 18 (14 generated)
Description was changed from ========== Remove additional uses of UseSubframeNavigationEntries in tests. BUG= ========== to ========== Remove additional uses of UseSubframeNavigationEntries in tests. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by creis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Remove additional uses of UseSubframeNavigationEntries in tests. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Remove additional uses of UseSubframeNavigationEntries in tests. There's no longer a PageState mismatch from bug 617239, so we can re-enable the test expectations for these tests. BUG=236848, 617239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
creis@chromium.org changed reviewers: + nasko@chromium.org
The CQ bit was checked by creis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Here's another set, removing the last uses of UseSubframeNavigationEntries from NavigationControllerBrowserTest. https://codereview.chromium.org/2614913002/diff/20001/content/browser/frame_h... File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/2614913002/diff/20001/content/browser/frame_h... content/browser/frame_host/navigation_controller_impl_browsertest.cc:5113: DISABLED_BackTwiceToIframeWithContent) { I almost re-enabled this test, but there's still one remaining issue from https://crbug.com/618100 in --site-per-process mode. I have some thoughts for how to fix which I'll post to that bug.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by creis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483658823025770,
"parent_rev": "42fdc659ccc288d4a3a01f202c7d667e76b04192", "commit_rev":
"ebfd33fdbbe2b78234fd30c6fdbddfc3d162e06d"}
Message was sent while issue was closed.
Description was changed from ========== Remove additional uses of UseSubframeNavigationEntries in tests. There's no longer a PageState mismatch from bug 617239, so we can re-enable the test expectations for these tests. BUG=236848, 617239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Remove additional uses of UseSubframeNavigationEntries in tests. There's no longer a PageState mismatch from bug 617239, so we can re-enable the test expectations for these tests. BUG=236848, 617239 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2614913002 Cr-Commit-Position: refs/heads/master@{#441854} Committed: https://chromium.googlesource.com/chromium/src/+/ebfd33fdbbe2b78234fd30c6fdbd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ebfd33fdbbe2b78234fd30c6fdbd... |
