Implements CSSPropertyAPI for the text-underline-position property.

Implements CSSPropertyAPI for the text-underline-position property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyTextUnderlinePosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPITextUnderlinePosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPITextUnderlinePosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPITextUnderlinePosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2614903002
Cr-Commit-Position: refs/heads/master@{#441879}
Committed: https://chromium.googlesource.com/chromium/src/+/f3d3571792a07271b3cd8faac95bb9dc04c4a0bf

[aazzam, 2017-01-05 04:05:18]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-05 04:13:22]

lgtm

https://codereview.chromium.org/2614903002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextUnderlinePosition.cpp
(right):

https://codereview.chromium.org/2614903002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextUnderlinePosition.cpp:22:
DCHECK(RuntimeEnabledFeatures::css3TextDecorationsEnabled());
These lines are duplicated :)

[aazzam, 2017-01-05 04:28:33]

Description was changed from

==========
Implemented CSSPropertyAPI for text-underline-position property.

Added CSSPropertyAPITextUnderlinePosition which implements
CSSPropertyAPI for the text-underline-position property. Moved parsing
logic from CSSPropertyParser to the .cpp file. Added flag to
CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for text-underline-position property.

Added CSSPropertyAPITextUnderlinePosition which implements
CSSPropertyAPI for the text-underline-position property.
Parsing logic is the same as before, just was moved from 
CSSPropertyParser to the .cpp file. Added flag to 
CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

[aazzam, 2017-01-05 22:05:36]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-05 22:05:36]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-05 22:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2614903002/#ps20001
(title: "fixed dependencies, changed year")

[aazzam, 2017-01-05 22:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2614903002/#ps20001
(title: "fixed dependencies, changed year")

[commit-bot: I haz the power, 2017-01-05 22:06:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 22:08:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:08:43]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-01-06 03:11:29]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-06 03:11:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2614903002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-06 03:11:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 05:04:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483672289188530,
"parent_rev": "840051ec723d7dcacc54b81b8c77957c8ce8dad3", "commit_rev":
"f3d3571792a07271b3cd8faac95bb9dc04c4a0bf"}

[commit-bot: I haz the power, 2017-01-06 05:05:20]

Description was changed from

==========
Implemented CSSPropertyAPI for text-underline-position property.

Added CSSPropertyAPITextUnderlinePosition which implements
CSSPropertyAPI for the text-underline-position property.
Parsing logic is the same as before, just was moved from 
CSSPropertyParser to the .cpp file. Added flag to 
CSSProperties.in so that the .h file will be generated.

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for text-underline-position property.

Added CSSPropertyAPITextUnderlinePosition which implements
CSSPropertyAPI for the text-underline-position property.
Parsing logic is the same as before, just was moved from 
CSSPropertyParser to the .cpp file. Added flag to 
CSSProperties.in so that the .h file will be generated.

BUG=668012

Review-Url: https://codereview.chromium.org/2614903002
Cr-Commit-Position: refs/heads/master@{#441879}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3d3571792a07271b3cd8faac95b...
==========

[commit-bot: I haz the power, 2017-01-06 05:05:21]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f3d3571792a07271b3cd8faac95b...

[aazzam, 2017-01-08 02:55:07]

Description was changed from

==========
Implemented CSSPropertyAPI for text-underline-position property.

Added CSSPropertyAPITextUnderlinePosition which implements
CSSPropertyAPI for the text-underline-position property.
Parsing logic is the same as before, just was moved from 
CSSPropertyParser to the .cpp file. Added flag to 
CSSProperties.in so that the .h file will be generated.

BUG=668012

Review-Url: https://codereview.chromium.org/2614903002
Cr-Commit-Position: refs/heads/master@{#441879}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3d3571792a07271b3cd8faac95b...
==========

to

==========
Implements CSSPropertyAPI for the text-underline-position property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyTextUnderlinePosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPITextUnderlinePosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPITextUnderlinePosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPITextUnderlinePosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2614903002
Cr-Commit-Position: refs/heads/master@{#441879}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3d3571792a07271b3cd8faac95b...
==========