Cache web contents in credit card scanner.

Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner. This flag is
disabled by default and will be removed once the best theme for the scan
dialog is determined.

BUG=678642
Review-Url: https://codereview.chromium.org/2614883003
Cr-Commit-Position: refs/heads/master@{#442071}
Committed: https://chromium.googlesource.com/chromium/src/+/4b77a92aea7e6ccf635a787a18005d70e50e2dd5

[please use gerrit instead, 2017-01-05 16:49:18]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 16:49:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 17:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 17:36:23]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-01-05 18:40:37]

Description was changed from

==========
Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

BUG=678642
==========

to

==========
Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner.

BUG=678642
==========

[please use gerrit instead, 2017-01-05 18:41:13]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 18:41:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-01-05 18:41:40]

Description was changed from

==========
Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner.

BUG=678642
==========

to

==========
Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner. This flag is
disabled by default and will be removed once the best theme for the scan
dialog is determined.

BUG=678642
==========

[please use gerrit instead, 2017-01-05 18:42:00]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2017-01-05 18:42:50]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2017-01-05 18:42:50]

Dan, ptal.

[gone, 2017-01-05 19:41:41]

Welp, looked at it today anyway because compiling takes forever.

lgtm

[commit-bot: I haz the power, 2017-01-05 19:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 19:41:48]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-01-05 19:45:20]

rouslan@chromium.org changed reviewers:
+ isherman@chromium.org, tedchoc@chromium.org

[please use gerrit instead, 2017-01-05 19:45:20]

Ted, owners ptal credit_card_scanner_view_android.cc.

Ilya, owners ptal histograms.xml.

[Ted C, 2017-01-05 21:24:10]

On 2017/01/05 19:45:20, rouslan wrote:
> Ted, owners ptal credit_card_scanner_view_android.cc.
> 
> Ilya, owners ptal histograms.xml.

credit_card_scanner_view_android.cc - lgtm

[please use gerrit instead, 2017-01-06 17:31:09]

rouslan@chromium.org changed reviewers:
+ rkaplow@chromium.org
- isherman@chromium.org

[please use gerrit instead, 2017-01-06 17:31:09]

rkaplow, owners ptal histograms.xml

[rkaplow, 2017-01-06 19:05:20]

lgtm

[please use gerrit instead, 2017-01-06 19:11:27]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:12:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 20:48:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-01-06 21:03:10]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-01-06 21:03:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, rkaplow@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2614883003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-06 21:03:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:33:20]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[please use gerrit instead, 2017-01-06 21:34:11]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:34:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-01-06 22:16:10]

isherman@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2017-01-06 22:16:10]

histograms.xml lgtm

[commit-bot: I haz the power, 2017-01-06 22:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483738451713340,
"parent_rev": "4333928031cee6b8ff32d2fcddd45d537f7ea500", "commit_rev":
"4b77a92aea7e6ccf635a787a18005d70e50e2dd5"}

[commit-bot: I haz the power, 2017-01-06 22:18:30]

Description was changed from

==========
Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner. This flag is
disabled by default and will be removed once the best theme for the scan
dialog is determined.

BUG=678642
==========

to

==========
Cache web contents in credit card scanner.

It's much safer to cache the WebContents instead of WindowAndroid to
deal with tab reparenting, for example. This patch changes the credit
card OCR scanner extension point to cache the WebContents instead of
WindowAndroid.

This patch also adds chrome://flags/#autofill-scan-theme-dialog to be
used by Chrome's implementation of the credit card scanner. This flag is
disabled by default and will be removed once the best theme for the scan
dialog is determined.

BUG=678642

Review-Url: https://codereview.chromium.org/2614883003
Cr-Commit-Position: refs/heads/master@{#442071}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b77a92aea7e6ccf635a787a1800...
==========

[commit-bot: I haz the power, 2017-01-06 22:18:34]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4b77a92aea7e6ccf635a787a1800...