Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 2614883002: DevTools: lighten the workspaces settings ui a bit. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
alph, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: lighten the workspaces settings ui a bit. Review-Url: https://codereview.chromium.org/2614883002 Cr-Commit-Position: refs/heads/master@{#442138} Committed: https://chromium.googlesource.com/chromium/src/+/29318e7298cf35d87e41eda1cb066dcdc776fa47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js View 3 chunks +14 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/editFileSystemView.css View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
pfeldman
3 years, 11 months ago (2017-01-05 02:19:31 UTC) #2
alph
lgtm
3 years, 11 months ago (2017-01-05 02:31:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614883002/1
3 years, 11 months ago (2017-01-05 18:52:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/358464)
3 years, 11 months ago (2017-01-05 22:41:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614883002/1
3 years, 11 months ago (2017-01-07 00:25:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/29318e7298cf35d87e41eda1cb066dcdc776fa47
3 years, 11 months ago (2017-01-07 02:09:23 UTC) #12
lushnikov
3 years, 11 months ago (2017-01-23 03:36:17 UTC) #14
Message was sent while issue was closed.
good stuff!

Powered by Google App Engine
This is Rietveld 408576698