third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html - Issue 2614873002: Ensure navigator.getVRDisplays always resolves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html

Issue 2614873002: Ensure navigator.getVRDisplays always resolves. (Closed)

Patch Set: addressing test nits from ddorwin@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html

diff --git a/third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html b/third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html

new file mode 100644

index 0000000000000000000000000000000000000000..9623898ed35b952a74bf0a1eb6ab2dcbe2177848

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html

@@ -0,0 +1,12 @@

+<!DOCTYPE html>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script>

+promise_test(t => navigator.getVRDisplays().then(devices => {

+ assert_true(devices != null);

+ assert_equals(typeof devices, "object");

ddorwin 2017/01/06 02:26:10 `devices instanceof Array` should work and be a li

+ assert_greater_than_equal(0, devices.length);

ddorwin 2017/01/06 02:26:09 You could add: if (0 < devices.length) assert_tr

+}), "Test that getVRDisplays always resolves to at least an empty sequence.");

ddorwin 2017/01/06 02:26:10 Should "to" be "with"? (Not sure if you missed thi

+</script>

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | third_party/WebKit/Source/modules/vr/VRController.cpp » ('j') | no next file with comments »