third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html - Issue 2614873002: Ensure navigator.getVRDisplays always resolves.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/vr/getVRDisplays_always_resolves.html

Issue 2614873002: Ensure navigator.getVRDisplays always resolves. (Closed)

Patch Set: addressing test nits from ddorwin@ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5

	6 promise_test(t => navigator.getVRDisplays().then(devices => {

	7 assert_true(devices != null);

	8 assert_equals(typeof devices, "object");
	ddorwin 2017/01/06 02:26:10 `devices instanceof Array` should work and be a li `devices instanceof Array` should work and be a little better.
	9 assert_greater_than_equal(0, devices.length);
	ddorwin 2017/01/06 02:26:09 You could add: if (0 < devices.length) assert_tr You could add: if (0 < devices.length) assert_true(devices[0] instanceof VRDisplay); This would check the type on devices that have a display. (If we don't already, we should check this in the mocked tests too.)
	10 }), "Test that getVRDisplays always resolves to at least an empty sequence.");
	ddorwin 2017/01/06 02:26:10 Should "to" be "with"? (Not sure if you missed thi Should "to" be "with"? (Not sure if you missed this comment previously or decided not ot change it.)
	11

	12 </script>

OLD	NEW