Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2614833005: Migrate WTF::Vector::append() to ::push_back() [part 10 of N] (Closed)

Created:
3 years, 11 months ago by pilgrim_google
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, michaeln, tyoshino+watch_chromium.org, Yoav Weiss, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() [part 10 of N] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/core/loader/. There are too many references to change them all at once, so this CL is part 10 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2614833005 Cr-Commit-Position: refs/heads/master@{#441833} Committed: https://chromium.googlesource.com/chromium/src/+/63351a797c6e1d4956efa89d082da3a7eb0b17b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParserTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 11 months ago (2017-01-05 21:50:57 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-05 23:11:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614833005/1
3 years, 11 months ago (2017-01-06 02:17:04 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:30:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/63351a797c6e1d4956efa89d082d...

Powered by Google App Engine
This is Rietveld 408576698