Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2614783002: Remove tld checks: IsGoogleSearchUrl does TLD check now. (Closed)

Created:
3 years, 11 months ago by Maria
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove tld checks: IsGoogleSearchUrl does TLD check now. BUG=656193 Committed: https://crrev.com/38c3c8c88851805c89a1953ee459c2350f7750f6 Cr-Commit-Position: refs/heads/master@{#441468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M chrome/browser/android/url_utilities.cc View 2 chunks +1 line, -58 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Maria
3 years, 11 months ago (2017-01-04 19:26:02 UTC) #2
Ted C
lgtm
3 years, 11 months ago (2017-01-04 20:47:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614783002/1
3 years, 11 months ago (2017-01-04 20:48:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 21:21:25 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 21:24:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38c3c8c88851805c89a1953ee459c2350f7750f6
Cr-Commit-Position: refs/heads/master@{#441468}

Powered by Google App Engine
This is Rietveld 408576698