Use switches for CSSPropertyMetadata::isDescriptorOnly.

Use switches for CSSPropertyMetadata::isDescriptorOnly.
This allows CSSProperties.in to have unordered entries.

Generated code is now:

namespace blink {

bool CSSPropertyMetadata::isDescriptorOnly(CSSPropertyID property) {
  switch(property) {
    case CSSPropertyInvalid:
      ASSERT_NOT_REACHED();
      return false;
    case CSSPropertyFontDisplay:
    case CSSPropertyMinZoom:
    case CSSPropertyOrientation:
    case CSSPropertyUnicodeRange:
    case CSSPropertyMaxZoom:
    case CSSPropertyUserZoom:
    case CSSPropertySrc:
      return true;
    default:
      return false;
  }
}

BUG=677884
Review-Url: https://codereview.chromium.org/2614773007
Cr-Commit-Position: refs/heads/master@{#441894}
Committed: https://chromium.googlesource.com/chromium/src/+/950a485a2b8a36beefe4bb7140274399390745c3

[ktyliu, 2017-01-06 04:29:18]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 04:29:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-06 04:37:47]

ktyliu@chromium.org changed reviewers:
+ bugsnash@chromium.org

[ktyliu, 2017-01-06 04:37:48]

Hi Bugs,

Does this change look okay to you?

If it's fine I can then add Sasha to it.

Thanks,
Kevin

[ktyliu, 2017-01-06 05:08:09]

ktyliu@chromium.org changed reviewers:
+ sashab@chromium.org

[ktyliu, 2017-01-06 05:08:09]

Adding Sasha, as Bugs has already went on weekend adventure :)

[sashab, 2017-01-06 05:12:49]

WOW this is awesome!! Thanks for putting the generated snippet in the CL
description.

Did our generation tools actually make this easier... ? No way ;)

LGTM im sure bugs is enjoying his adventure :)

[sashab, 2017-01-06 05:13:07]

+cc alancutter because oh my god how cool does this look alan!! D:

[alancutter (OOO until 2018), 2017-01-06 05:18:59]

On 2017/01/06 at 05:13:07, sashab wrote:
> +cc alancutter because oh my god how cool does this look alan!! D:

IT'S SO CLEAN AAAA.

lgtm

[commit-bot: I haz the power, 2017-01-06 06:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 06:11:46]

Dry run: This issue passed the CQ dry run.

[ktyliu_google, 2017-01-06 06:33:20]

The CQ bit was checked by ktyliu@google.com

[commit-bot: I haz the power, 2017-01-06 06:33:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 06:37:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483684400987750,
"parent_rev": "8b5d6d41bd50a323fd9e0cca5920548b34f6add6", "commit_rev":
"950a485a2b8a36beefe4bb7140274399390745c3"}

[commit-bot: I haz the power, 2017-01-06 06:38:06]

Description was changed from

==========
Use switches for CSSPropertyMetadata::isDescriptorOnly.
This allows CSSProperties.in to have unordered entries.

Generated code is now:

namespace blink {

bool CSSPropertyMetadata::isDescriptorOnly(CSSPropertyID property) {
  switch(property) {
    case CSSPropertyInvalid:
      ASSERT_NOT_REACHED();
      return false;
    case CSSPropertyFontDisplay:
    case CSSPropertyMinZoom:
    case CSSPropertyOrientation:
    case CSSPropertyUnicodeRange:
    case CSSPropertyMaxZoom:
    case CSSPropertyUserZoom:
    case CSSPropertySrc:
      return true;
    default:
      return false;
  }
}

BUG=677884
==========

to

==========
Use switches for CSSPropertyMetadata::isDescriptorOnly.
This allows CSSProperties.in to have unordered entries.

Generated code is now:

namespace blink {

bool CSSPropertyMetadata::isDescriptorOnly(CSSPropertyID property) {
  switch(property) {
    case CSSPropertyInvalid:
      ASSERT_NOT_REACHED();
      return false;
    case CSSPropertyFontDisplay:
    case CSSPropertyMinZoom:
    case CSSPropertyOrientation:
    case CSSPropertyUnicodeRange:
    case CSSPropertyMaxZoom:
    case CSSPropertyUserZoom:
    case CSSPropertySrc:
      return true;
    default:
      return false;
  }
}

BUG=677884

Review-Url: https://codereview.chromium.org/2614773007
Cr-Commit-Position: refs/heads/master@{#441894}
Committed:
https://chromium.googlesource.com/chromium/src/+/950a485a2b8a36beefe4bb714027...
==========

[commit-bot: I haz the power, 2017-01-06 06:38:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/950a485a2b8a36beefe4bb714027...