Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2614753004: Remove ScopedVector from bluetooth. (Closed)

Created:
3 years, 11 months ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from bluetooth. BUG=639089 Review-Url: https://codereview.chromium.org/2614753004 Cr-Commit-Position: refs/heads/master@{#442096} Committed: https://chromium.googlesource.com/chromium/src/+/dc3d7f9ad23aef74a3b1f1d2fc83d999d3da80e4

Patch Set 1 #

Patch Set 2 : rev #

Patch Set 3 : last win bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -222 lines) Patch
M device/bluetooth/bluetooth_adapter_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win_unittest.cc View 1 3 chunks +14 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 4 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 1 6 chunks +26 lines, -29 lines 0 comments Download
M device/bluetooth/bluetooth_device_win_unittest.cc View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_filter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_filter.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.h View 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win_fake.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win_fake.cc View 5 chunks +11 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.h View 1 8 chunks +22 lines, -14 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 1 2 18 chunks +46 lines, -59 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 1 4 chunks +4 lines, -7 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_service.cc View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Avi (use Gerrit)
scheib, you're in; ptal.
3 years, 11 months ago (2017-01-06 20:48:23 UTC) #12
scheib
LGTM
3 years, 11 months ago (2017-01-06 23:31:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614753004/40001
3 years, 11 months ago (2017-01-06 23:33:00 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 23:38:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dc3d7f9ad23aef74a3b1f1d2fc83...

Powered by Google App Engine
This is Rietveld 408576698