Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 2614743004: Fix 'hyphens: auto' to work only when wrapping is allowed (Closed)

Created:
3 years, 11 months ago by kojii
Modified:
3 years, 11 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'hyphens: auto' to work only when line wrapping is allowed This patch fixes 'hyphens: auto' to work only when line wrapping is allowed. BUG=678356 Review-Url: https://codereview.chromium.org/2614743004 Cr-Commit-Position: refs/heads/master@{#441805} Committed: https://chromium.googlesource.com/chromium/src/+/6715bcb1960f4062e2f6daf261e3da76c7d62019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-auto-nowrap.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/hyphens/hyphens-auto-nowrap-expected.html View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
kojii
PTAL.
3 years, 11 months ago (2017-01-05 19:47:20 UTC) #5
eae
LGTM
3 years, 11 months ago (2017-01-05 22:58:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614743004/1
3 years, 11 months ago (2017-01-06 00:57:01 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 01:48:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6715bcb1960f4062e2f6daf261e3...

Powered by Google App Engine
This is Rietveld 408576698