|
|
Chromium Code Reviews
Description[NTP::PhysicalWeb] Enable by default and depend on physical web flag.
Make Physical Web page provider depend on #enable-physical-web flag.
Reason: M57 feature freeze is close and we want this provider in M57.
We depend on their flag, so that in case they unlaunch their feature, we
do the same. We add our own flag in case we decide to unlaunch our own
feature, while Physical Web in general should works.
BUG=666647
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2614733002
Cr-Commit-Position: refs/heads/master@{#442210}
Committed: https://chromium.googlesource.com/chromium/src/+/e6dc58fc9701e2f1bec9c49f1375e871c8b0eb51
Patch Set 1 #Patch Set 2 : rebase. #Patch Set 3 : rebase. #Patch Set 4 : clean rebase. #
Messages
Total messages: 43 (35 generated)
Description was changed from ========== [NTP::PhysicalWeb] Enable by default and depend on physical web flag. Make Physical Web page provider depend on #enable-physical-web flag. Reason: M57 feature freeze is close and we want this provider in M57. We depend on their flag, so that in case they unlaunch their feature, we do the same. We add our own flag in case we decide to unlaunch our own feature, while Physical Web in general should works. BUG=666647 ========== to ========== [NTP::PhysicalWeb] Enable by default and depend on physical web flag. Make Physical Web page provider depend on #enable-physical-web flag. Reason: M57 feature freeze is close and we want this provider in M57. We depend on their flag, so that in case they unlaunch their feature, we do the same. We add our own flag in case we decide to unlaunch our own feature, while Physical Web in general should works. BUG=666647 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vitaliii@chromium.org changed reviewers: + jkrcal@chromium.org
[small CL] Hi jkrcal@, Please take a look at my components/ntp_snippets change.
vitaliii@chromium.org changed reviewers: + bauerb@chromium.org
[small CL] Hi bauerb@, Please take a look at my snippets_internals_.* change.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2017/01/04 16:59:53, Bernhard Bauer wrote: > lgtm lgtm
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by vitaliii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org, jkrcal@chromium.org Link to the patchset: https://codereview.chromium.org/2614733002/#ps40001 (title: "rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by vitaliii@chromium.org
The CQ bit was checked by vitaliii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org, jkrcal@chromium.org Link to the patchset: https://codereview.chromium.org/2614733002/#ps60001 (title: "clean rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483950084520010,
"parent_rev": "4c28543e8b6e6897f0f0dbb66cb9035a1872b422", "commit_rev":
"e6dc58fc9701e2f1bec9c49f1375e871c8b0eb51"}
Message was sent while issue was closed.
Description was changed from ========== [NTP::PhysicalWeb] Enable by default and depend on physical web flag. Make Physical Web page provider depend on #enable-physical-web flag. Reason: M57 feature freeze is close and we want this provider in M57. We depend on their flag, so that in case they unlaunch their feature, we do the same. We add our own flag in case we decide to unlaunch our own feature, while Physical Web in general should works. BUG=666647 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [NTP::PhysicalWeb] Enable by default and depend on physical web flag. Make Physical Web page provider depend on #enable-physical-web flag. Reason: M57 feature freeze is close and we want this provider in M57. We depend on their flag, so that in case they unlaunch their feature, we do the same. We add our own flag in case we decide to unlaunch our own feature, while Physical Web in general should works. BUG=666647 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2614733002 Cr-Commit-Position: refs/heads/master@{#442210} Committed: https://chromium.googlesource.com/chromium/src/+/e6dc58fc9701e2f1bec9c49f1375... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/e6dc58fc9701e2f1bec9c49f1375... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
