Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2614733002: [NTP::PhysicalWeb] Enable by default and depend on physical web flag. (Closed)

Created:
3 years, 11 months ago by vitaliii
Modified:
3 years, 11 months ago
Reviewers:
Bernhard Bauer, jkrcal
CC:
chromium-reviews, noyau+watch_chromium.org, arv+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::PhysicalWeb] Enable by default and depend on physical web flag. Make Physical Web page provider depend on #enable-physical-web flag. Reason: M57 feature freeze is close and we want this provider in M57. We depend on their flag, so that in case they unlaunch their feature, we do the same. We add our own flag in case we decide to unlaunch our own feature, while Physical Web in general should works. BUG=666647 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2614733002 Cr-Commit-Position: refs/heads/master@{#442210} Committed: https://chromium.googlesource.com/chromium/src/+/e6dc58fc9701e2f1bec9c49f1375e871c8b0eb51

Patch Set 1 #

Patch Set 2 : rebase. #

Patch Set 3 : rebase. #

Patch Set 4 : clean rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/snippets_internals.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M components/ntp_snippets/features.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 43 (35 generated)
vitaliii
[small CL] Hi jkrcal@, Please take a look at my components/ntp_snippets change.
3 years, 11 months ago (2017-01-04 16:56:52 UTC) #5
vitaliii
[small CL] Hi bauerb@, Please take a look at my snippets_internals_.* change.
3 years, 11 months ago (2017-01-04 16:57:28 UTC) #7
Bernhard Bauer
lgtm
3 years, 11 months ago (2017-01-04 16:59:53 UTC) #8
jkrcal
On 2017/01/04 16:59:53, Bernhard Bauer wrote: > lgtm lgtm
3 years, 11 months ago (2017-01-05 10:23:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614733002/40001
3 years, 11 months ago (2017-01-05 15:52:14 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/207590)
3 years, 11 months ago (2017-01-05 17:21:40 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614733002/60001
3 years, 11 months ago (2017-01-09 08:21:28 UTC) #40
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 08:46:21 UTC) #43
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e6dc58fc9701e2f1bec9c49f1375...

Powered by Google App Engine
This is Rietveld 408576698