Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6072)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 2614703002: Remove the temporary flag to disable the sync confirmation page on linux an windows. (Closed)
Patch Set: Remove the temporary flag to disable the sync confirmation page on linux an windows. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.h
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.h b/chrome/browser/ui/sync/one_click_signin_sync_starter.h
index efd09d5004363dcd4576dfcc77af0e39436577d7..a2cd1b7ad8f02f645b332c650176b364d3de5163 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.h
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.h
@@ -260,8 +260,10 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,
// Prevents Sync from running until configuration is complete.
std::unique_ptr<syncer::SyncSetupInProgressHandle> sync_blocker_;
- // Temporary flag to disable new sync confirm page if user choose to create a
- // new profile after the corp account signin.
+ // Temporary flag used only on macOS to disable new sync confirm page if user
+ // choose to create a new profile.
+ //
+ // TODO(msarda): Remove this flag once the https://crbug.com/677012 fixed.
bool skip_sync_confirm_;
base::WeakPtrFactory<OneClickSigninSyncStarter> weak_pointer_factory_;
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698