Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 26147006: Fix three bugs in the equals() implementations for css gradients. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Fix three bugs in the equals() implementations for css gradients. 1. Linear gradients were considered equal if the first gradient has no x and y position and the second has no x but does have y. 2. Same as 1, for radial gradients. (This doesn't happen in practice as CSSParser::parseRadialGradient rejects such input, so no test for this case.) 3. Radial gradients without x and y position weren't considered equal even if they were. Found by clang's -Wunused-value in combination with https://codereview.chromium.org/26205004/ BUG=none R=eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159903

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M LayoutTests/cssom/cssvalue-comparison.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/cssom/cssvalue-comparison-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 2 3 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eae
LGTM
6 years, 4 months ago (2013-10-17 19:30:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26147006/17001
6 years, 4 months ago (2013-10-17 19:38:02 UTC) #2
Nico
6 years, 4 months ago (2013-10-17 22:16:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r159903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698