Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2614663009: PPC: fix smi compare in DoBoundsCheck (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
Reviewers:
john.yan, JoranSiu
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: fix smi compare in DoBoundsCheck CmplSmiLiteral should be used to compare smi R=joransiu@ca.ibm.com, jyan@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2614663009 Cr-Commit-Position: refs/heads/master@{#42108} Committed: https://chromium.googlesource.com/v8/v8/+/0a4f52972f71c40d8bc5eaef4279e2b2890734bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-06 00:07:04 UTC) #1
john.yan
lgtm
3 years, 11 months ago (2017-01-06 04:35:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614663009/1
3 years, 11 months ago (2017-01-06 14:22:09 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 14:41:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0a4f52972f71c40d8bc5eaef4279e2b2890...

Powered by Google App Engine
This is Rietveld 408576698