third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp ('k') | third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index e4cd79e652a8656111e5676e22ed8635839cf14a..c5da0e87b559864a7bad30795e61e6aeb2dc3117 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -116,7 +116,7 @@ class ServiceWorkerRegistrationArray {

WebType webServiceWorkerRegistrations) {

HeapVector<Member<ServiceWorkerRegistration>> registrations;

for (auto& registration : *webServiceWorkerRegistrations) {

- registrations.append(

+ registrations.push_back(

ServiceWorkerRegistration::take(resolver, std::move(registration)));

}

return registrations;