third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

index beb0093a88123be7d8f633fa9af90b986b1d8daa..7d5865324e8dc62b5689f4fd7a5c45a4a61f621f 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

@@ -294,7 +294,7 @@ class StubWebServiceWorkerProvider {

m_owner.m_registerCallCount++;

m_owner.m_registerScope = pattern;

m_owner.m_registerScriptURL = scriptURL;

- m_registrationCallbacksToDelete.append(std::move(callbacks));

+ m_registrationCallbacksToDelete.push_back(std::move(callbacks));

}

void getRegistration(

@@ -303,7 +303,7 @@ class StubWebServiceWorkerProvider {

override {

m_owner.m_getRegistrationCallCount++;

m_owner.m_getRegistrationURL = documentURL;

- m_getRegistrationCallbacksToDelete.append(std::move(callbacks));

+ m_getRegistrationCallbacksToDelete.push_back(std::move(callbacks));

}

bool validateScopeAndScriptURL(const WebURL& scope,