third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/permissions/Permissions.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

diff --git a/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp b/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

index a738ac0d1f16e935061db18fedad2c89af7dd9e9..ece11f530e4ea7cb904157b9db48665d2a287efb 100644

--- a/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

+++ b/third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp

@@ -50,7 +50,7 @@ static void getObjectStack(const LayoutObject* ro,

Vector<const LayoutObject*>* roStack) {

roStack->clear();

while (ro) {

- roStack->append(ro);

+ roStack->push_back(ro);

ro = ro->parent();

}

@@ -125,8 +125,8 @@ static bool intersectsRect(const LayoutObject* renderer, const IntRect& rect) {

static void addToOcclusions(const LayoutBox* renderer,

Vector<IntRect>& occlusions) {

- occlusions.append(IntRect(roundedIntPoint(renderer->localToAbsolute()),

- flooredIntSize(renderer->size())));

+ occlusions.push_back(IntRect(roundedIntPoint(renderer->localToAbsolute()),

+ flooredIntSize(renderer->size())));

}

static void addTreeToOcclusions(const LayoutObject* renderer,