Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp
diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
index 22a986cffba167440d65a1a188ae7e1579b45759..329a9a2eba1dd88205e036801c86b43008c662ed 100644
--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp
+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp
@@ -222,7 +222,7 @@ ScriptPromise Permissions::requestAll(
}
if (internalIndex == kNotFound) {
internalIndex = internalPermissions.size();
- internalPermissions.append(std::move(descriptor));
+ internalPermissions.push_back(std::move(descriptor));
}
callerIndexToInternalIndex[i] = internalIndex;
}
@@ -242,7 +242,7 @@ ScriptPromise Permissions::requestAll(
Vector<PermissionDescriptorPtr> internalPermissionsCopy;
internalPermissionsCopy.reserveCapacity(internalPermissions.size());
for (const auto& descriptor : internalPermissions)
- internalPermissionsCopy.append(descriptor->Clone());
+ internalPermissionsCopy.push_back(descriptor->Clone());
service->RequestPermissions(
std::move(internalPermissions),
@@ -300,7 +300,7 @@ void Permissions::batchTaskComplete(
HeapVector<Member<PermissionStatus>> result;
result.reserveInitialCapacity(callerIndexToInternalIndex.size());
for (int internalIndex : callerIndexToInternalIndex) {
- result.append(PermissionStatus::createAndListen(
+ result.push_back(PermissionStatus::createAndListen(
resolver->getExecutionContext(), results[internalIndex],
descriptors[internalIndex]->Clone()));
}

Powered by Google App Engine
This is Rietveld 408576698