Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
index 316c3b7c4be7c2028258bace305272119c5014ce..faaecadf3bc98f6d3570b5e574cca1c1bdbc6652 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
@@ -164,7 +164,7 @@ static bool parseMandatoryConstraintsDictionary(
return false;
for (const auto& iter : mandatoryConstraintsHashMap)
- mandatory.append(NameValueStringConstraint(iter.key, iter.value));
+ mandatory.push_back(NameValueStringConstraint(iter.key, iter.value));
return true;
}
@@ -183,7 +183,7 @@ static bool parseOptionalConstraintsVectorElement(
bool ok = DictionaryHelper::get(constraint, key, value);
if (!ok)
return false;
- optionalConstraintsVector.append(NameValueStringConstraint(key, value));
+ optionalConstraintsVector.push_back(NameValueStringConstraint(key, value));
return true;
}
@@ -469,7 +469,7 @@ static WebMediaConstraints createFromNamedConstraints(
parseOldStyleNames(context, elementAsList, false, advancedElement,
ignoredErrorState);
if (!advancedElement.isEmpty())
- advancedVector.append(advancedElement);
+ advancedVector.push_back(advancedElement);
}
constraints.initialize(basic, advancedVector);
return constraints;
@@ -684,7 +684,7 @@ WebMediaConstraints convertConstraintsToWeb(
WebMediaTrackConstraintSet advancedElement;
copyConstraintSet(element, NakedValueDisposition::kTreatAsExact,
advancedElement);
- advancedBuffer.append(advancedElement);
+ advancedBuffer.push_back(advancedElement);
}
}
constraints.initialize(constraintBuffer, advancedBuffer);
@@ -813,7 +813,7 @@ StringOrStringSequence convertStringSequence(
if (input.size() > 1) {
Vector<String> buffer;
for (const auto& scanner : input)
- buffer.append(scanner);
+ buffer.push_back(scanner);
theStrings.setStringSequence(buffer);
} else if (input.size() > 0) {
theStrings.setString(input[0]);
@@ -831,7 +831,7 @@ StringOrStringSequenceOrConstrainDOMStringParameters convertString(
if (inputBuffer.size() > 1) {
Vector<String> buffer;
for (const auto& scanner : inputBuffer)
- buffer.append(scanner);
+ buffer.push_back(scanner);
outputUnion.setStringSequence(buffer);
} else if (inputBuffer.size() > 0) {
outputUnion.setString(inputBuffer[0]);
@@ -910,7 +910,7 @@ void convertConstraints(const WebMediaConstraints& input,
for (const auto& it : input.advanced()) {
MediaTrackConstraintSet element;
convertConstraintSet(it, NakedValueDisposition::kTreatAsExact, element);
- advancedVector.append(element);
+ advancedVector.push_back(element);
}
if (!advancedVector.isEmpty())
output.setAdvanced(advancedVector);

Powered by Google App Engine
This is Rietveld 408576698