Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 146 matching lines @@
     const Dictionary& mandatoryConstraintsDictionary,
     Vector<NameValueStringConstraint>& mandatory) {
   DummyExceptionStateForTesting exceptionState;
   const HashMap<String, String>& mandatoryConstraintsHashMap =
       mandatoryConstraintsDictionary.getOwnPropertiesAsStringHashMap(
           exceptionState);
   if (exceptionState.hadException())
     return false;
 
   for (const auto& iter : mandatoryConstraintsHashMap)
-    mandatory.append(NameValueStringConstraint(iter.key, iter.value));
+    mandatory.push_back(NameValueStringConstraint(iter.key, iter.value));
   return true;
 }
 
 static bool parseOptionalConstraintsVectorElement(
     const Dictionary& constraint,
     Vector<NameValueStringConstraint>& optionalConstraintsVector) {
   DummyExceptionStateForTesting exceptionState;
   const Vector<String>& localNames =
       constraint.getPropertyNames(exceptionState);
   if (exceptionState.hadException())
     return false;
   if (localNames.size() != 1)
     return false;
   const String& key = localNames[0];
   String value;
   bool ok = DictionaryHelper::get(constraint, key, value);
   if (!ok)
     return false;
-  optionalConstraintsVector.append(NameValueStringConstraint(key, value));
+  optionalConstraintsVector.push_back(NameValueStringConstraint(key, value));
   return true;
 }
 
 // Old style parser. Deprecated.
 static bool parse(const Dictionary& constraintsDictionary,
                   Vector<NameValueStringConstraint>& optional,
                   Vector<NameValueStringConstraint>& mandatory) {
   if (constraintsDictionary.isUndefinedOrNull())
     return true;
 
@@ skipping 265 matching lines @@
     return constraints;
   // We ignore unknow names and syntax errors in optional constraints.
   MediaErrorState ignoredErrorState;
   Vector<WebMediaTrackConstraintSet> advancedVector;
   for (const auto& optionalConstraint : optional) {
     WebMediaTrackConstraintSet advancedElement;
     Vector<NameValueStringConstraint> elementAsList(1, optionalConstraint);
     parseOldStyleNames(context, elementAsList, false, advancedElement,
                        ignoredErrorState);
     if (!advancedElement.isEmpty())
-      advancedVector.append(advancedElement);
+      advancedVector.push_back(advancedElement);
   }
   constraints.initialize(basic, advancedVector);
   return constraints;
 }
 
 // Deprecated.
 WebMediaConstraints create(ExecutionContext* context,
                            const Dictionary& constraintsDictionary,
                            MediaErrorState& errorState) {
   Vector<NameValueStringConstraint> optional;
@@ skipping 194 matching lines @@
   WebMediaConstraints constraints;
   WebMediaTrackConstraintSet constraintBuffer;
   Vector<WebMediaTrackConstraintSet> advancedBuffer;
   copyConstraintSet(constraintsIn, NakedValueDisposition::kTreatAsIdeal,
                     constraintBuffer);
   if (constraintsIn.hasAdvanced()) {
     for (const auto& element : constraintsIn.advanced()) {
       WebMediaTrackConstraintSet advancedElement;
       copyConstraintSet(element, NakedValueDisposition::kTreatAsExact,
                         advancedElement);
-      advancedBuffer.append(advancedElement);
+      advancedBuffer.push_back(advancedElement);
     }
   }
   constraints.initialize(constraintBuffer, advancedBuffer);
   return constraints;
 }
 
 WebMediaConstraints create(ExecutionContext* context,
                            const MediaTrackConstraints& constraintsIn,
                            MediaErrorState& errorState) {
   WebMediaConstraints standardForm = convertConstraintsToWeb(constraintsIn);
@@ skipping 108 matching lines @@
   }
   return outputUnion;
 }
 
 StringOrStringSequence convertStringSequence(
     const WebVector<WebString>& input) {
   StringOrStringSequence theStrings;
   if (input.size() > 1) {
     Vector<String> buffer;
     for (const auto& scanner : input)
-      buffer.append(scanner);
+      buffer.push_back(scanner);
     theStrings.setStringSequence(buffer);
   } else if (input.size() > 0) {
     theStrings.setString(input[0]);
   }
   return theStrings;
 }
 
 StringOrStringSequenceOrConstrainDOMStringParameters convertString(
     const StringConstraint& input,
     NakedValueDisposition nakedTreatment) {
   StringOrStringSequenceOrConstrainDOMStringParameters outputUnion;
   if (useNakedNonNumeric(input, nakedTreatment)) {
     WebVector<WebString> inputBuffer(
         getNakedValue<WebVector<WebString>>(input, nakedTreatment));
     if (inputBuffer.size() > 1) {
       Vector<String> buffer;
       for (const auto& scanner : inputBuffer)
-        buffer.append(scanner);
+        buffer.push_back(scanner);
       outputUnion.setStringSequence(buffer);
     } else if (inputBuffer.size() > 0) {
       outputUnion.setString(inputBuffer[0]);
     }
   } else if (!input.isEmpty()) {
     ConstrainDOMStringParameters output;
     if (input.hasExact())
       output.setExact(convertStringSequence(input.exact()));
     if (input.hasIdeal())
       output.setIdeal(convertStringSequence(input.ideal()));
@@ skipping 58 matching lines @@
 void convertConstraints(const WebMediaConstraints& input,
                         MediaTrackConstraints& output) {
   if (input.isNull())
     return;
   convertConstraintSet(input.basic(), NakedValueDisposition::kTreatAsIdeal,
                        output);
   HeapVector<MediaTrackConstraintSet> advancedVector;
   for (const auto& it : input.advanced()) {
     MediaTrackConstraintSet element;
     convertConstraintSet(it, NakedValueDisposition::kTreatAsExact, element);
-    advancedVector.append(element);
+    advancedVector.push_back(element);
   }
   if (!advancedVector.isEmpty())
     output.setAdvanced(advancedVector);
 }
 
 }  // namespace MediaConstraintsImpl
 }  // namespace blink