Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/WebKit/Source/modules/cachestorage/Cache.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/cachestorage/Cache.cpp
diff --git a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
index ff0d44b5ea169cdedf34aa4937820886a8b1fff0..2c89c8a3f81507533e3dfee6e60354d80f4347f7 100644
--- a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
+++ b/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
@@ -79,7 +79,7 @@ class CacheWithResponsesCallbacks
ScriptState::Scope scope(m_resolver->getScriptState());
HeapVector<Member<Response>> responses;
for (size_t i = 0; i < webResponses.size(); ++i)
- responses.append(
+ responses.push_back(
Response::create(m_resolver->getScriptState(), webResponses[i]));
m_resolver->resolve(responses);
m_resolver.clear();
@@ -145,7 +145,7 @@ class CacheWithRequestsCallbacks
ScriptState::Scope scope(m_resolver->getScriptState());
HeapVector<Member<Request>> requests;
for (size_t i = 0; i < webRequests.size(); ++i)
- requests.append(
+ requests.push_back(
Request::create(m_resolver->getScriptState(), webRequests[i]));
m_resolver->resolve(requests);
m_resolver.clear();
@@ -424,9 +424,9 @@ ScriptPromise Cache::add(ScriptState* scriptState,
ASSERT(!request.isNull());
HeapVector<Member<Request>> requests;
if (request.isRequest()) {
- requests.append(request.getAsRequest());
+ requests.push_back(request.getAsRequest());
} else {
- requests.append(
+ requests.push_back(
Request::create(scriptState, request.getAsUSVString(), exceptionState));
if (exceptionState.hadException())
return ScriptPromise();
@@ -441,10 +441,10 @@ ScriptPromise Cache::addAll(ScriptState* scriptState,
HeapVector<Member<Request>> requests;
for (RequestInfo request : rawRequests) {
if (request.isRequest()) {
- requests.append(request.getAsRequest());
+ requests.push_back(request.getAsRequest());
} else {
- requests.append(Request::create(scriptState, request.getAsUSVString(),
- exceptionState));
+ requests.push_back(Request::create(scriptState, request.getAsUSVString(),
+ exceptionState));
if (exceptionState.hadException())
return ScriptPromise();
}

Powered by Google App Engine
This is Rietveld 408576698