third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp - Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

Issue 2614663008: Migrate WTF::Vector::append() to ::push_back() [part 13 of N] (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp ('k') | third_party/WebKit/Source/modules/cachestorage/Cache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

index d73dd6b4e3e65b7af6d0d35224b4ad6f204e73ab..940731497b60f6c757c7647fc49af52b9b92d378 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

@@ -84,10 +84,11 @@ void BluetoothRemoteGATTService::GetCharacteristicsCallback(

HeapVector<Member<BluetoothRemoteGATTCharacteristic>> gattCharacteristics;

gattCharacteristics.reserveInitialCapacity(characteristics->size());

for (const auto& characteristic : characteristics.value()) {

- gattCharacteristics.append(device()->getOrCreateRemoteGATTCharacteristic(

- resolver->getExecutionContext(), characteristic->instance_id,

- serviceInstanceId, characteristic->uuid, characteristic->properties,

- this));

+ gattCharacteristics.push_back(

+ device()->getOrCreateRemoteGATTCharacteristic(

+ resolver->getExecutionContext(), characteristic->instance_id,

+ serviceInstanceId, characteristic->uuid,

+ characteristic->properties, this));

}

resolver->resolve(gattCharacteristics);

} else {